2020-03-11 15:53:05

by rishi gupta

Subject: [PATCH 1/1] pwm: pca9685: use gpio core provided macro GPIO_LINE_DIRECTION_OUT

GPIO core recently added macro to uniformly specify direction
of a GPIO Line, so use it.

Signed-off-by: Rishi Gupta <[email protected]>
---
drivers/pwm/pwm-pca9685.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
index b2a9e77..e2bac1e 100644
--- a/drivers/pwm/pwm-pca9685.c
+++ b/drivers/pwm/pwm-pca9685.c
@@ -168,7 +168,7 @@ static int pca9685_pwm_gpio_get_direction(struct gpio_chip *chip,
unsigned int offset)
{
/* Always out */
- return 0;
+ return GPIO_LINE_DIRECTION_OUT;
}

static int pca9685_pwm_gpio_direction_input(struct gpio_chip *gpio,
--
2.7.4

2020-03-11 16:44:32

by Uwe Kleine-König

Subject: Re: [PATCH 1/1] pwm: pca9685: use gpio core provided macro GPIO_LINE_DIRECTION_OUT

On Wed, Mar 11, 2020 at 09:22:20PM +0530, Rishi Gupta wrote:
> GPIO core recently added macro to uniformly specify direction
> of a GPIO Line, so use it.
>
> Signed-off-by: Rishi Gupta <[email protected]>

Acked-by: Uwe Kleine-K?nig <[email protected]>

Best regards and thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |