2020-03-16 15:50:17

by Adriana Kobylak

Subject: [PATCH] tools/bootconfig: Makefile: Create destination directory

From: Adriana Kobylak <[email protected]>

The DESTDIR path may not be available to the caller, such as
compiling the bootconfig tool from a Yocto native recipe. Have
the Makefile create the directory instead.

Signed-off-by: Adriana Kobylak <[email protected]>
---
tools/bootconfig/Makefile | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/bootconfig/Makefile b/tools/bootconfig/Makefile
index a6146ac..470b6f0 100644
--- a/tools/bootconfig/Makefile
+++ b/tools/bootconfig/Makefile
@@ -14,6 +14,7 @@ bootconfig: ../../lib/bootconfig.c main.c $(HEADER)
$(CC) $(filter %.c,$^) $(CFLAGS) -o $@

install: $(PROGS)
+ install -d $(DESTDIR)$(bindir)
install bootconfig $(DESTDIR)$(bindir)

test: bootconfig
--
1.8.3.1

2020-03-17 13:15:59

by Masami Hiramatsu

Subject: Re: [PATCH] tools/bootconfig: Makefile: Create destination directory

On Mon, 16 Mar 2020 10:49:26 -0500
Adriana Kobylak <[email protected]> wrote:

> From: Adriana Kobylak <[email protected]>
>
> The DESTDIR path may not be available to the caller, such as
> compiling the bootconfig tool from a Yocto native recipe. Have
> the Makefile create the directory instead.

OK, this looks good to me.

Acked-by: Masami Hiramatsu <[email protected]>

Thanks!

>
> Signed-off-by: Adriana Kobylak <[email protected]>
> ---
> tools/bootconfig/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/bootconfig/Makefile b/tools/bootconfig/Makefile
> index a6146ac..470b6f0 100644
> --- a/tools/bootconfig/Makefile
> +++ b/tools/bootconfig/Makefile
> @@ -14,6 +14,7 @@ bootconfig: ../../lib/bootconfig.c main.c $(HEADER)
> $(CC) $(filter %.c,$^) $(CFLAGS) -o $@
>
> install: $(PROGS)
> + install -d $(DESTDIR)$(bindir)
> install bootconfig $(DESTDIR)$(bindir)
>
> test: bootconfig
> --
> 1.8.3.1
>


--
Masami Hiramatsu <[email protected]>