2020-03-17 02:06:39

by Anson Huang

Subject: [PATCH] soc: imx8m: No need to put node when of_find_compatible_node() failed

No need to put node when of_find_compatible_node() failed, return
immediately to simplify the code.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/soc/imx/soc-imx8m.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
index 719e1f18..7b0759a 100644
--- a/drivers/soc/imx/soc-imx8m.c
+++ b/drivers/soc/imx/soc-imx8m.c
@@ -53,11 +53,11 @@ static u32 __init imx8mq_soc_revision(void)
struct device_node *np;
void __iomem *ocotp_base;
u32 magic;
- u32 rev = 0;
+ u32 rev;

np = of_find_compatible_node(NULL, NULL, "fsl,imx8mq-ocotp");
if (!np)
- goto out;
+ return 0;

ocotp_base = of_iomap(np, 0);
WARN_ON(!ocotp_base);
@@ -78,9 +78,8 @@ static u32 __init imx8mq_soc_revision(void)
soc_uid |= readl_relaxed(ocotp_base + OCOTP_UID_LOW);

iounmap(ocotp_base);
-
-out:
of_node_put(np);
+
return rev;
}

--
2.7.4

2020-04-14 16:05:25

by Shawn Guo

Subject: Re: [PATCH] soc: imx8m: No need to put node when of_find_compatible_node() failed

On Tue, Mar 17, 2020 at 09:37:33AM +0800, Anson Huang wrote:
> No need to put node when of_find_compatible_node() failed, return
> immediately to simplify the code.
>
> Signed-off-by: Anson Huang <[email protected]>

Applied, thanks.