2020-03-18 01:47:47

by Anson Huang

Subject: [PATCH] clk: imx: clk-sscg-pll: Remove unnecessary blank lines

Remove many unnecessary blank lines for cleanup.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/clk/imx/clk-sscg-pll.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/clk/imx/clk-sscg-pll.c b/drivers/clk/imx/clk-sscg-pll.c
index d4a2be1..773d8a5 100644
--- a/drivers/clk/imx/clk-sscg-pll.c
+++ b/drivers/clk/imx/clk-sscg-pll.c
@@ -72,7 +72,6 @@ struct clk_sscg_pll_setup {
int divr2, divf2;
int divq;
int bypass;
-
uint64_t vco1;
uint64_t vco2;
uint64_t fout;
@@ -86,11 +85,8 @@ struct clk_sscg_pll_setup {
struct clk_sscg_pll {
struct clk_hw hw;
const struct clk_ops ops;
-
void __iomem *base;
-
struct clk_sscg_pll_setup setup;
-
u8 parent;
u8 bypass1;
u8 bypass2;
@@ -194,7 +190,6 @@ static int clk_sscg_pll2_find_setup(struct clk_sscg_pll_setup *setup,
struct clk_sscg_pll_setup *temp_setup,
uint64_t ref)
{
-
int ret;

if (ref < PLL_STAGE1_MIN_FREQ || ref > PLL_STAGE1_MAX_FREQ)
@@ -253,7 +248,6 @@ static int clk_sscg_pll1_find_setup(struct clk_sscg_pll_setup *setup,
struct clk_sscg_pll_setup *temp_setup,
uint64_t ref)
{
-
int ret;

if (ref < PLL_REF_MIN_FREQ || ref > PLL_REF_MAX_FREQ)
@@ -280,7 +274,6 @@ static int clk_sscg_pll_find_setup(struct clk_sscg_pll_setup *setup,
temp_setup.fout_request = rate;

switch (try_bypass) {
-
case PLL_BYPASS2:
if (prate == rate) {
setup->bypass = PLL_BYPASS2;
@@ -288,11 +281,9 @@ static int clk_sscg_pll_find_setup(struct clk_sscg_pll_setup *setup,
ret = 0;
}
break;
-
case PLL_BYPASS1:
ret = clk_sscg_pll2_find_setup(setup, &temp_setup, prate);
break;
-
case PLL_BYPASS_NONE:
ret = clk_sscg_pll1_find_setup(setup, &temp_setup, prate);
break;
@@ -301,7 +292,6 @@ static int clk_sscg_pll_find_setup(struct clk_sscg_pll_setup *setup,
return ret;
}

-
static int clk_sscg_pll_is_prepared(struct clk_hw *hw)
{
struct clk_sscg_pll *pll = to_clk_sscg_pll(hw);
--
2.7.4

2020-03-18 11:16:46

by Abel Vesa

Subject: Re: [PATCH] clk: imx: clk-sscg-pll: Remove unnecessary blank lines

On 20-03-18 09:39:25, Anson Huang wrote:
> Remove many unnecessary blank lines for cleanup.
>
> Signed-off-by: Anson Huang <[email protected]>

Reviewed-by: Abel Vesa <[email protected]>

> ---
> drivers/clk/imx/clk-sscg-pll.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-sscg-pll.c b/drivers/clk/imx/clk-sscg-pll.c
> index d4a2be1..773d8a5 100644
> --- a/drivers/clk/imx/clk-sscg-pll.c
> +++ b/drivers/clk/imx/clk-sscg-pll.c
> @@ -72,7 +72,6 @@ struct clk_sscg_pll_setup {
> int divr2, divf2;
> int divq;
> int bypass;
> -
> uint64_t vco1;
> uint64_t vco2;
> uint64_t fout;
> @@ -86,11 +85,8 @@ struct clk_sscg_pll_setup {
> struct clk_sscg_pll {
> struct clk_hw hw;
> const struct clk_ops ops;
> -
> void __iomem *base;
> -
> struct clk_sscg_pll_setup setup;
> -
> u8 parent;
> u8 bypass1;
> u8 bypass2;
> @@ -194,7 +190,6 @@ static int clk_sscg_pll2_find_setup(struct clk_sscg_pll_setup *setup,
> struct clk_sscg_pll_setup *temp_setup,
> uint64_t ref)
> {
> -
> int ret;
>
> if (ref < PLL_STAGE1_MIN_FREQ || ref > PLL_STAGE1_MAX_FREQ)
> @@ -253,7 +248,6 @@ static int clk_sscg_pll1_find_setup(struct clk_sscg_pll_setup *setup,
> struct clk_sscg_pll_setup *temp_setup,
> uint64_t ref)
> {
> -
> int ret;
>
> if (ref < PLL_REF_MIN_FREQ || ref > PLL_REF_MAX_FREQ)
> @@ -280,7 +274,6 @@ static int clk_sscg_pll_find_setup(struct clk_sscg_pll_setup *setup,
> temp_setup.fout_request = rate;
>
> switch (try_bypass) {
> -
> case PLL_BYPASS2:
> if (prate == rate) {
> setup->bypass = PLL_BYPASS2;
> @@ -288,11 +281,9 @@ static int clk_sscg_pll_find_setup(struct clk_sscg_pll_setup *setup,
> ret = 0;
> }
> break;
> -
> case PLL_BYPASS1:
> ret = clk_sscg_pll2_find_setup(setup, &temp_setup, prate);
> break;
> -
> case PLL_BYPASS_NONE:
> ret = clk_sscg_pll1_find_setup(setup, &temp_setup, prate);
> break;
> @@ -301,7 +292,6 @@ static int clk_sscg_pll_find_setup(struct clk_sscg_pll_setup *setup,
> return ret;
> }
>
> -
> static int clk_sscg_pll_is_prepared(struct clk_hw *hw)
> {
> struct clk_sscg_pll *pll = to_clk_sscg_pll(hw);
> --
> 2.7.4
>

2020-03-19 19:59:57

by Stephen Boyd

Subject: Re: [PATCH] clk: imx: clk-sscg-pll: Remove unnecessary blank lines

Quoting Anson Huang (2020-03-17 18:39:25)
> Remove many unnecessary blank lines for cleanup.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2020-04-20 16:40:26

by Shawn Guo

Subject: Re: [PATCH] clk: imx: clk-sscg-pll: Remove unnecessary blank lines

On Wed, Mar 18, 2020 at 09:39:25AM +0800, Anson Huang wrote:
> Remove many unnecessary blank lines for cleanup.
>
> Signed-off-by: Anson Huang <[email protected]>

Applied, thanks.