2020-04-06 16:44:33

by Prabhakar Mahadev Lad

[permalink] [raw]
Subject: [PATCH v5 4/5] ARM: dts: imx6qdl-wandboard: Drop clock-frequency property from ov5645 node

clock-frequency property has been deprecated in ov5645 binding. This patch
makes sure it matches the bindings by dropping clock-frequency property
from ov5645 node.

Signed-off-by: Lad Prabhakar <[email protected]>
---
arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
index c070893c509e..fa01cad65335 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
@@ -126,7 +126,6 @@
reg = <0x3c>;
clocks = <&clks IMX6QDL_CLK_CKO2>;
clock-names = "xclk";
- clock-frequency = <24000000>;
vdddo-supply = <&reg_1p8v>;
vdda-supply = <&reg_2p8v>;
vddd-supply = <&reg_1p5v>;
--
2.20.1


2020-04-06 17:47:00

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH v5 4/5] ARM: dts: imx6qdl-wandboard: Drop clock-frequency property from ov5645 node

Hi Prabhakar,

Thank you for the patch.

On Mon, Apr 06, 2020 at 05:42:40PM +0100, Lad Prabhakar wrote:
> clock-frequency property has been deprecated in ov5645 binding. This patch
> makes sure it matches the bindings by dropping clock-frequency property
> from ov5645 node.
>
> Signed-off-by: Lad Prabhakar <[email protected]>

This looks good to me, but could you also address imx6qdl-pico.dtsi ?
With that,

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> index c070893c509e..fa01cad65335 100644
> --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> @@ -126,7 +126,6 @@
> reg = <0x3c>;
> clocks = <&clks IMX6QDL_CLK_CKO2>;
> clock-names = "xclk";
> - clock-frequency = <24000000>;
> vdddo-supply = <&reg_1p8v>;
> vdda-supply = <&reg_2p8v>;
> vddd-supply = <&reg_1p5v>;

--
Regards,

Laurent Pinchart