2020-09-30 14:58:27

by Alexandre Belloni

[permalink] [raw]
Subject: [PATCH] i2c: aT91: remove legacy DMA left overs

Commit dc6df6e90de9 ("i2c: at91: remove legacy DMA support") removed legcy
DMA support from the driver. Remove the last use of the definitions from
linux/platform_data/dma-atmel.h and stop including this header.

Signed-off-by: Alexandre Belloni <[email protected]>
---
drivers/i2c/busses/i2c-at91-master.c | 1 -
drivers/i2c/busses/i2c-at91.h | 2 --
2 files changed, 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c
index 66864f9cf7ac..1cceb6866689 100644
--- a/drivers/i2c/busses/i2c-at91-master.c
+++ b/drivers/i2c/busses/i2c-at91-master.c
@@ -26,7 +26,6 @@
#include <linux/of_device.h>
#include <linux/pinctrl/consumer.h>
#include <linux/platform_device.h>
-#include <linux/platform_data/dma-atmel.h>
#include <linux/pm_runtime.h>

#include "i2c-at91.h"
diff --git a/drivers/i2c/busses/i2c-at91.h b/drivers/i2c/busses/i2c-at91.h
index eae673ae786c..942e9c3973bb 100644
--- a/drivers/i2c/busses/i2c-at91.h
+++ b/drivers/i2c/busses/i2c-at91.h
@@ -18,7 +18,6 @@
#include <linux/dma-mapping.h>
#include <linux/dmaengine.h>
#include <linux/i2c.h>
-#include <linux/platform_data/dma-atmel.h>
#include <linux/platform_device.h>

#define AT91_I2C_TIMEOUT msecs_to_jiffies(100) /* transfer timeout */
@@ -123,7 +122,6 @@ struct at91_twi_pdata {
bool has_adv_dig_filtr;
bool has_ana_filtr;
bool has_clear_cmd;
- struct at_dma_slave dma_slave;
};

struct at91_twi_dma {
--
2.26.2


2020-10-11 10:07:38

by Codrin Ciubotariu

[permalink] [raw]
Subject: Re: [PATCH] i2c: aT91: remove legacy DMA left overs

On 30.09.2020 17:56, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Commit dc6df6e90de9 ("i2c: at91: remove legacy DMA support") removed legcy
> DMA support from the driver. Remove the last use of the definitions from
> linux/platform_data/dma-atmel.h and stop including this header.
>
> Signed-off-by: Alexandre Belloni <[email protected]>

There is a capital 'T' in the subject, not sure it matters. Otherwise:

Reviewed-by: Codrin Ciubotariu <[email protected]>

Thanks!

2020-11-03 20:38:42

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: aT91: remove legacy DMA left overs

On Wed, Sep 30, 2020 at 04:56:54PM +0200, Alexandre Belloni wrote:
> Commit dc6df6e90de9 ("i2c: at91: remove legacy DMA support") removed legcy
> DMA support from the driver. Remove the last use of the definitions from
> linux/platform_data/dma-atmel.h and stop including this header.
>
> Signed-off-by: Alexandre Belloni <[email protected]>

Fixed the typo in the commit message and applied to for-next, thanks!


Attachments:
(No filename) (436.00 B)
signature.asc (849.00 B)
Download all attachments