2020-04-09 16:36:18

by Colin King

Subject: [PATCH] drm/i915: remove redundant assignment to variable err

From: Colin Ian King <[email protected]>

The variable err is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/gpu/drm/i915/gem/selftests/i915_gem_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object.c
index 2b6db6f799de..faa5b6d91795 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object.c
@@ -14,7 +14,7 @@ static int igt_gem_object(void *arg)
{
struct drm_i915_private *i915 = arg;
struct drm_i915_gem_object *obj;
- int err = -ENOMEM;
+ int err;

/* Basic test to ensure we can create an object */

--
2.25.1

2020-04-09 19:21:14

by Chris Wilson

Subject: Re: [PATCH] drm/i915: remove redundant assignment to variable err

Quoting Colin King (2020-04-09 14:31:07)
> From: Colin Ian King <[email protected]>
>
> The variable err is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Could be useful... No, let's not look at that function again.
Reviewed-by: Chris Wilson <[email protected]>
-Chris