2020-04-21 03:30:04

by Ani Sinha

Subject: [PATCH] PCI: pciehp: Cleanup unused EMI() and HP_SUPR_RM() macros

We do not use PCIE hotplug surprise (PCI_EXP_SLTCAP_HPS) bit anymore.
Consequently HP_SUPR_RM() macro is no longer used. Let's clean it up.
EMI() macro also seems to be unused. So removing it as well. Thanks
Mika Westerberg <[email protected]> for
pointing it out.

Signed-off-by: Ani Sinha <[email protected]>
Reviewed-by: Mika Westerberg <[email protected]>
---
drivers/pci/hotplug/pciehp.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
index ae44f46..4fd200d 100644
--- a/drivers/pci/hotplug/pciehp.h
+++ b/drivers/pci/hotplug/pciehp.h
@@ -148,8 +148,6 @@ struct controller {
#define MRL_SENS(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP)
#define ATTN_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP)
#define PWR_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP)
-#define HP_SUPR_RM(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_HPS)
-#define EMI(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP)
#define NO_CMD_CMPL(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS)
#define PSN(ctrl) (((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19)

--
2.7.4

2020-04-23 19:39:01

by Bjorn Helgaas

Subject: Re: [PATCH] PCI: pciehp: Cleanup unused EMI() and HP_SUPR_RM() macros

On Tue, Apr 21, 2020 at 08:57:50AM +0530, Ani Sinha wrote:
> We do not use PCIE hotplug surprise (PCI_EXP_SLTCAP_HPS) bit anymore.
> Consequently HP_SUPR_RM() macro is no longer used. Let's clean it up.
> EMI() macro also seems to be unused. So removing it as well. Thanks
> Mika Westerberg <[email protected]> for
> pointing it out.
>
> Signed-off-by: Ani Sinha <[email protected]>
> Reviewed-by: Mika Westerberg <[email protected]>

Applied to pci/hotplug for v5.8, thanks!

> ---
> drivers/pci/hotplug/pciehp.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
> index ae44f46..4fd200d 100644
> --- a/drivers/pci/hotplug/pciehp.h
> +++ b/drivers/pci/hotplug/pciehp.h
> @@ -148,8 +148,6 @@ struct controller {
> #define MRL_SENS(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP)
> #define ATTN_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP)
> #define PWR_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP)
> -#define HP_SUPR_RM(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_HPS)
> -#define EMI(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP)
> #define NO_CMD_CMPL(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS)
> #define PSN(ctrl) (((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19)
>
> --
> 2.7.4
>