2020-04-23 06:29:49

by Zou Wei

Subject: [PATCH -next] arm64: smp: Make cpus_stuck_in_kernel static

Fix the following sparse warning:

arch/arm64/kernel/smp.c:68:5: warning: symbol 'cpus_stuck_in_kernel'
was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
arch/arm64/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 061f60f..1d06af4 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -65,7 +65,7 @@ EXPORT_PER_CPU_SYMBOL(cpu_number);
*/
struct secondary_data secondary_data;
/* Number of CPUs which aren't online, but looping in kernel text. */
-int cpus_stuck_in_kernel;
+static int cpus_stuck_in_kernel;

enum ipi_msg_type {
IPI_RESCHEDULE,
--
2.6.2

2020-04-28 14:52:37

by Will Deacon

Subject: Re: [PATCH -next] arm64: smp: Make cpus_stuck_in_kernel static

On Thu, 23 Apr 2020 14:33:26 +0800, Zou Wei wrote:
> Fix the following sparse warning:
>
> arch/arm64/kernel/smp.c:68:5: warning: symbol 'cpus_stuck_in_kernel'
> was not declared. Should it be static?

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64: smp: Make cpus_stuck_in_kernel static
https://git.kernel.org/arm64/c/2eaf63ba84dc

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev