2020-04-23 07:10:19

by Peng Fan

Subject: [PATCH 1/4] firmware: imx: scu-pd: fix cm40 power domain

From: Peng Fan <[email protected]>

The postfix needs to be false. Alought compiler use 0 for postfix now,
and take start_from as 0, it is better we add explicit false to postfix.

Fixes: 705dcca91d0a("firmware: imx: scu-pd: add power domain for I2C and INTMUX in CM40 SS")
Signed-off-by: Peng Fan <[email protected]>
---
drivers/firmware/imx/scu-pd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index fb5523aa16ee..d1b313fa7b96 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -167,8 +167,8 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
{ "dc0-pll", IMX_SC_R_DC_0_PLL_0, 2, true, 0 },

/* CM40 SS */
- { "cm40_i2c", IMX_SC_R_M4_0_I2C, 1, 0 },
- { "cm40_intmux", IMX_SC_R_M4_0_INTMUX, 1, 0 },
+ { "cm40_i2c", IMX_SC_R_M4_0_I2C, 1, false, 0 },
+ { "cm40_intmux", IMX_SC_R_M4_0_INTMUX, 1, false, 0 },
};

static const struct imx_sc_pd_soc imx8qxp_scu_pd = {
--
2.16.4

2020-04-23 10:04:17

by Aisheng Dong

Subject: RE: [PATCH 1/4] firmware: imx: scu-pd: fix cm40 power domain

> From: Peng Fan <[email protected]>
> Sent: Thursday, April 23, 2020 3:00 PM
>
> The postfix needs to be false. Alought compiler use 0 for postfix now, and take
> start_from as 0, it is better we add explicit false to postfix.
>
> Fixes: 705dcca91d0a("firmware: imx: scu-pd: add power domain for I2C and
> INTMUX in CM40 SS")
> Signed-off-by: Peng Fan <[email protected]>

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng