2020-04-23 12:13:42

by Zou Wei

Subject: [PATCH -next] efi/libstub/arm: Make install_memreserve_table static

Fix the following sparse warning:

drivers/firmware/efi/libstub/arm-stub.c:68:6: warning:
symbol 'install_memreserve_table' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/firmware/efi/libstub/arm-stub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/libstub/arm-stub.c b/drivers/firmware/efi/libstub/arm-stub.c
index 99a5cde..8a26cc1 100644
--- a/drivers/firmware/efi/libstub/arm-stub.c
+++ b/drivers/firmware/efi/libstub/arm-stub.c
@@ -65,7 +65,7 @@ static struct screen_info *setup_graphics(void)
return si;
}

-void install_memreserve_table(void)
+static void install_memreserve_table(void)
{
struct linux_efi_memreserve *rsv;
efi_guid_t memreserve_table_guid = LINUX_EFI_MEMRESERVE_TABLE_GUID;
--
2.6.2

2020-04-23 19:05:10

by Ard Biesheuvel

Subject: Re: [PATCH -next] efi/libstub/arm: Make install_memreserve_table static

On Thu, 23 Apr 2020 at 14:02, Zou Wei <[email protected]> wrote:
>
> Fix the following sparse warning:
>
> drivers/firmware/efi/libstub/arm-stub.c:68:6: warning:
> symbol 'install_memreserve_table' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/firmware/efi/libstub/arm-stub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/arm-stub.c b/drivers/firmware/efi/libstub/arm-stub.c
> index 99a5cde..8a26cc1 100644
> --- a/drivers/firmware/efi/libstub/arm-stub.c
> +++ b/drivers/firmware/efi/libstub/arm-stub.c
> @@ -65,7 +65,7 @@ static struct screen_info *setup_graphics(void)
> return si;
> }
>
> -void install_memreserve_table(void)
> +static void install_memreserve_table(void)
> {
> struct linux_efi_memreserve *rsv;
> efi_guid_t memreserve_table_guid = LINUX_EFI_MEMRESERVE_TABLE_GUID;
> --
> 2.6.2
>

Applied to efi/next, thanks.