2020-04-23 14:25:55

by Anson Huang

[permalink] [raw]
Subject: [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h

Now that linux/firmware/imx/types.h is removed, remove it from the
include list in imx-scu.c driver.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/firmware/imx/imx-scu.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
index f71eaa5..f3340fa 100644
--- a/drivers/firmware/imx/imx-scu.c
+++ b/drivers/firmware/imx/imx-scu.c
@@ -8,7 +8,6 @@
*/

#include <linux/err.h>
-#include <linux/firmware/imx/types.h>
#include <linux/firmware/imx/ipc.h>
#include <linux/firmware/imx/sci.h>
#include <linux/interrupt.h>
--
2.7.4


2020-04-23 15:19:32

by Aisheng Dong

[permalink] [raw]
Subject: RE: [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h

> From: Anson Huang <[email protected]>
> Sent: Thursday, April 23, 2020 10:00 PM
>
> Now that linux/firmware/imx/types.h is removed, remove it from the include list
> in imx-scu.c driver.
>
> Signed-off-by: Anson Huang <[email protected]>

You need combine them in order to not break bisect.

Regards
Aisheng

> ---
> drivers/firmware/imx/imx-scu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
> index f71eaa5..f3340fa 100644
> --- a/drivers/firmware/imx/imx-scu.c
> +++ b/drivers/firmware/imx/imx-scu.c
> @@ -8,7 +8,6 @@
> */
>
> #include <linux/err.h>
> -#include <linux/firmware/imx/types.h>
> #include <linux/firmware/imx/ipc.h>
> #include <linux/firmware/imx/sci.h>
> #include <linux/interrupt.h>
> --
> 2.7.4