2020-04-24 20:08:36

by Sowjanya Komatineni

[permalink] [raw]
Subject: [PATCH 5.4.33 0/2] Fix for long operation cmds busy detection

This series is to backport the upstream patches that fixes busy detection
for long operation mmc commands by implementing Tegra specific timeout
callback to switch between finite and infinite HW busy detection wait
modes.


Sowjanya Komatineni (2):
sdhci: tegra: Implement Tegra specific set_timeout callback
sdhci: tegra: Enable MMC_CAP_WAIT_WHILE_BUSY host capability

drivers/mmc/host/sdhci-tegra.c | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)

--
2.7.4


2020-04-25 01:50:34

by Sasha Levin

[permalink] [raw]
Subject: Re: [PATCH 5.4.33 0/2] Fix for long operation cmds busy detection

On Fri, Apr 24, 2020 at 01:06:04PM -0700, Sowjanya Komatineni wrote:
>This series is to backport the upstream patches that fixes busy detection
>for long operation mmc commands by implementing Tegra specific timeout
>callback to switch between finite and infinite HW busy detection wait
>modes.
>
>
>Sowjanya Komatineni (2):
> sdhci: tegra: Implement Tegra specific set_timeout callback
> sdhci: tegra: Enable MMC_CAP_WAIT_WHILE_BUSY host capability

What regression do these patches fix?

--
Thanks,
Sasha

2020-04-25 02:45:23

by Sowjanya Komatineni

[permalink] [raw]
Subject: Re: [PATCH 5.4.33 0/2] Fix for long operation cmds busy detection


On 4/24/20 6:45 PM, Sasha Levin wrote:
> External email: Use caution opening links or attachments
>
>
> On Fri, Apr 24, 2020 at 01:06:04PM -0700, Sowjanya Komatineni wrote:
>> This series is to backport the upstream patches that fixes busy
>> detection
>> for long operation mmc commands by implementing Tegra specific timeout
>> callback to switch between finite and infinite HW busy detection wait
>> modes.
>>
>>
>> Sowjanya Komatineni (2):
>>  sdhci: tegra: Implement Tegra specific set_timeout callback
>>  sdhci: tegra: Enable MMC_CAP_WAIT_WHILE_BUSY host capability
>
> What regression do these patches fix?
>
This isn't a regression as we don't have any known failures as of today
with the specific mmc devices we are using on our platforms.

But this patch fixes a long outstanding bug for sdhci-tegra to handle
long busy wait for mmc command operations that may take longer than host
max busy timeout. So, this is something that's missing from the
beginning and good to have.


> --
> Thanks,
> Sasha

2020-04-25 07:08:05

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.4.33 0/2] Fix for long operation cmds busy detection

On Fri, Apr 24, 2020 at 07:42:16PM -0700, Sowjanya Komatineni wrote:
>
> On 4/24/20 6:45 PM, Sasha Levin wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On Fri, Apr 24, 2020 at 01:06:04PM -0700, Sowjanya Komatineni wrote:
> > > This series is to backport the upstream patches that fixes busy
> > > detection
> > > for long operation mmc commands by implementing Tegra specific timeout
> > > callback to switch between finite and infinite HW busy detection wait
> > > modes.
> > >
> > >
> > > Sowjanya Komatineni (2):
> > > ?sdhci: tegra: Implement Tegra specific set_timeout callback
> > > ?sdhci: tegra: Enable MMC_CAP_WAIT_WHILE_BUSY host capability
> >
> > What regression do these patches fix?
> >
> This isn't a regression as we don't have any known failures as of today with
> the specific mmc devices we are using on our platforms.

Have you read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
?

> But this patch fixes a long outstanding bug for sdhci-tegra to handle long
> busy wait for mmc command operations that may take longer than host max busy
> timeout. So, this is something that's missing from the beginning and good to
> have.

So it's a new feature?

2020-05-13 11:12:20

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.4.33 0/2] Fix for long operation cmds busy detection

On Sat, Apr 25, 2020 at 09:04:08AM +0200, Greg KH wrote:
> On Fri, Apr 24, 2020 at 07:42:16PM -0700, Sowjanya Komatineni wrote:
> >
> > On 4/24/20 6:45 PM, Sasha Levin wrote:
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > On Fri, Apr 24, 2020 at 01:06:04PM -0700, Sowjanya Komatineni wrote:
> > > > This series is to backport the upstream patches that fixes busy
> > > > detection
> > > > for long operation mmc commands by implementing Tegra specific timeout
> > > > callback to switch between finite and infinite HW busy detection wait
> > > > modes.
> > > >
> > > >
> > > > Sowjanya Komatineni (2):
> > > > ?sdhci: tegra: Implement Tegra specific set_timeout callback
> > > > ?sdhci: tegra: Enable MMC_CAP_WAIT_WHILE_BUSY host capability
> > >
> > > What regression do these patches fix?
> > >
> > This isn't a regression as we don't have any known failures as of today with
> > the specific mmc devices we are using on our platforms.
>
> Have you read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> ?
>
> > But this patch fixes a long outstanding bug for sdhci-tegra to handle long
> > busy wait for mmc command operations that may take longer than host max busy
> > timeout. So, this is something that's missing from the beginning and good to
> > have.
>
> So it's a new feature?
>

Dropped from my queues due to lack of response.

greg k-h