2020-04-28 08:56:45

by Zou Wei

Subject: [PATCH -next] perf c2c: Remove unneeded semicolon

Fixes coccicheck warnings:

tools/perf/builtin-c2c.c:1712:2-3: Unneeded semicolon
tools/perf/builtin-c2c.c:1928:2-3: Unneeded semicolon
tools/perf/builtin-c2c.c:2962:2-3: Unneeded semicolon

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
tools/perf/builtin-c2c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 0d544c4..0e14c18 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -1709,7 +1709,7 @@ static struct c2c_dimension *get_dimension(const char *name)

if (!strcmp(dim->name, name))
return dim;
- };
+ }

return NULL;
}
@@ -1925,7 +1925,7 @@ static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
FILTER_HITM(tot_hitm);
default:
break;
- };
+ }

#undef FILTER_HITM

@@ -2959,7 +2959,7 @@ static int perf_c2c__record(int argc, const char **argv)

rec_argv[i++] = "-e";
rec_argv[i++] = perf_mem_events__name(j);
- };
+ }

if (all_user)
rec_argv[i++] = "--all-user";
--
2.6.2

2020-04-28 19:18:51

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH -next] perf c2c: Remove unneeded semicolon

Em Tue, Apr 28, 2020 at 04:58:56PM +0800, Zou Wei escreveu:
> Fixes coccicheck warnings:
>
> tools/perf/builtin-c2c.c:1712:2-3: Unneeded semicolon
> tools/perf/builtin-c2c.c:1928:2-3: Unneeded semicolon
> tools/perf/builtin-c2c.c:2962:2-3: Unneeded semicolon

Thanks, applied.

- Arnaldo

> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> tools/perf/builtin-c2c.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 0d544c4..0e14c18 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -1709,7 +1709,7 @@ static struct c2c_dimension *get_dimension(const char *name)
>
> if (!strcmp(dim->name, name))
> return dim;
> - };
> + }
>
> return NULL;
> }
> @@ -1925,7 +1925,7 @@ static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
> FILTER_HITM(tot_hitm);
> default:
> break;
> - };
> + }
>
> #undef FILTER_HITM
>
> @@ -2959,7 +2959,7 @@ static int perf_c2c__record(int argc, const char **argv)
>
> rec_argv[i++] = "-e";
> rec_argv[i++] = perf_mem_events__name(j);
> - };
> + }
>
> if (all_user)
> rec_argv[i++] = "--all-user";
> --
> 2.6.2
>

--

- Arnaldo

2020-05-08 13:10:43

by tip-bot2 for Haifeng Xu

Subject: [tip: perf/core] perf c2c: Remove unneeded semicolon

The following commit has been merged into the perf/core branch of tip:

Commit-ID: 2cca512ad2fe14d060838eaf8581cda600764141
Gitweb: https://git.kernel.org/tip/2cca512ad2fe14d060838eaf8581cda600764141
Author: Zou Wei <[email protected]>
AuthorDate: Tue, 28 Apr 2020 16:58:56 +08:00
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitterDate: Thu, 30 Apr 2020 10:48:32 -03:00

perf c2c: Remove unneeded semicolon

Fixes coccicheck warnings:

tools/perf/builtin-c2c.c:1712:2-3: Unneeded semicolon
tools/perf/builtin-c2c.c:1928:2-3: Unneeded semicolon
tools/perf/builtin-c2c.c:2962:2-3: Unneeded semicolon

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lore.kernel.org/lkml/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/builtin-c2c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 0d544c4..0e14c18 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -1709,7 +1709,7 @@ static struct c2c_dimension *get_dimension(const char *name)

if (!strcmp(dim->name, name))
return dim;
- };
+ }

return NULL;
}
@@ -1925,7 +1925,7 @@ static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
FILTER_HITM(tot_hitm);
default:
break;
- };
+ }

#undef FILTER_HITM

@@ -2959,7 +2959,7 @@ static int perf_c2c__record(int argc, const char **argv)

rec_argv[i++] = "-e";
rec_argv[i++] = perf_mem_events__name(j);
- };
+ }

if (all_user)
rec_argv[i++] = "--all-user";