2020-04-29 12:21:24

by Xiongfeng Wang

Subject: [PATCH] scsi: dpt_i2o: Remove always false 'chan < 0' statement

The channel index is represented by an unsigned variable 'u32 chan'. We
don't need to check whether it is less than zero. The following
statement is always false and let's remove it.
'chan < 0'

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Xiongfeng Wang <[email protected]>
---
drivers/scsi/dpt_i2o.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 02dff3a..2cf8895 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -1120,7 +1120,7 @@ static struct adpt_device* adpt_find_device(adpt_hba* pHba, u32 chan, u32 id, u6
{
struct adpt_device* d;

- if(chan < 0 || chan >= MAX_CHANNEL)
+ if (chan >= MAX_CHANNEL)
return NULL;

d = pHba->channel[chan].device[id];
--
1.7.12.4

2020-04-30 02:20:55

by Martin K. Petersen

Subject: Re: [PATCH] scsi: dpt_i2o: Remove always false 'chan < 0' statement

On Wed, 29 Apr 2020 20:10:18 +0800, Xiongfeng Wang wrote:

> The channel index is represented by an unsigned variable 'u32 chan'. We
> don't need to check whether it is less than zero. The following
> statement is always false and let's remove it.
> 'chan < 0'

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: dpt_i2o: Remove always false 'chan < 0' statement
https://git.kernel.org/mkp/scsi/c/6f41f08c88c5

--
Martin K. Petersen Oracle Linux Engineering