2020-04-30 03:15:40

by Zou Wei

Subject: [PATCH -next] KVM: MIPS/Emulate: Remove unneeded semicolon

Fixes coccicheck warnings:

arch/mips/kvm/emulate.c:1793:3-4: Unneeded semicolon
arch/mips/kvm/emulate.c:1968:3-4: Unneeded semicolon

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
arch/mips/kvm/emulate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
index 754094b..5c88bd1 100644
--- a/arch/mips/kvm/emulate.c
+++ b/arch/mips/kvm/emulate.c
@@ -1790,7 +1790,7 @@ static enum emulation_result kvm_mips_guest_cache_op(int (*fn)(unsigned long),
return EMULATE_EXCEPT;
default:
break;
- };
+ }
}
}

@@ -1965,7 +1965,7 @@ enum emulation_result kvm_mips_emulate_inst(u32 cause, u32 *opc,
break;
default:
goto unknown;
- };
+ }
break;
unknown:
#endif
--
2.6.2

2020-04-30 03:59:43

by Huacai Chen

Subject: Re: [PATCH -next] KVM: MIPS/Emulate: Remove unneeded semicolon

Reviewed-by: Huacai Chen <[email protected]>

On Thu, Apr 30, 2020 at 11:13 AM Zou Wei <[email protected]> wrote:
>
> Fixes coccicheck warnings:
>
> arch/mips/kvm/emulate.c:1793:3-4: Unneeded semicolon
> arch/mips/kvm/emulate.c:1968:3-4: Unneeded semicolon
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> arch/mips/kvm/emulate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
> index 754094b..5c88bd1 100644
> --- a/arch/mips/kvm/emulate.c
> +++ b/arch/mips/kvm/emulate.c
> @@ -1790,7 +1790,7 @@ static enum emulation_result kvm_mips_guest_cache_op(int (*fn)(unsigned long),
> return EMULATE_EXCEPT;
> default:
> break;
> - };
> + }
> }
> }
>
> @@ -1965,7 +1965,7 @@ enum emulation_result kvm_mips_emulate_inst(u32 cause, u32 *opc,
> break;
> default:
> goto unknown;
> - };
> + }
> break;
> unknown:
> #endif
> --
> 2.6.2
>

2020-05-14 07:59:02

by Thomas Bogendoerfer

Subject: Re: [PATCH -next] KVM: MIPS/Emulate: Remove unneeded semicolon

On Thu, Apr 30, 2020 at 11:19:36AM +0800, Zou Wei wrote:
> Fixes coccicheck warnings:
>
> arch/mips/kvm/emulate.c:1793:3-4: Unneeded semicolon
> arch/mips/kvm/emulate.c:1968:3-4: Unneeded semicolon
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> arch/mips/kvm/emulate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]