Modify the variable type of 'skip' member of struct stack_trace.
In theory, the 'skip' variable type should be unsigned int.
There are two reasons:
- The 'skip' only has two situation, 1)Positive value, 2)Zero
- The 'skip' of struct stack_trace has inconsistent type with struct
stack_trace_data, it makes a bit confusion in the relationship between
struct stack_trace and stack_trace_data.
Signed-off-by: Walter Wu <[email protected]>
Cc: Matthias Brugger <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Josh Poimboeuf <[email protected]>
Cc: Bart Van Assche <[email protected]>
Cc: Andrew Morton <[email protected]>
---
changes in v2:
modify the commit log to describe the matter more clearly.
---
include/linux/stacktrace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/stacktrace.h b/include/linux/stacktrace.h
index 83bd8cb475d7..b7af8cc13eda 100644
--- a/include/linux/stacktrace.h
+++ b/include/linux/stacktrace.h
@@ -64,7 +64,7 @@ void arch_stack_walk_user(stack_trace_consume_fn consume_entry, void *cookie,
struct stack_trace {
unsigned int nr_entries, max_entries;
unsigned long *entries;
- int skip; /* input argument: How many entries to skip */
+ unsigned int skip; /* input argument: How many entries to skip */
};
extern void save_stack_trace(struct stack_trace *trace);
--
2.18.0
On 4/20/20 6:35 PM, Walter Wu wrote:
> Modify the variable type of 'skip' member of struct stack_trace.
> In theory, the 'skip' variable type should be unsigned int.
> There are two reasons:
> - The 'skip' only has two situation, 1)Positive value, 2)Zero
> - The 'skip' of struct stack_trace has inconsistent type with struct
> stack_trace_data, it makes a bit confusion in the relationship between
> struct stack_trace and stack_trace_data.
Reviewed-by: Bart Van Assche <[email protected]>
On Wed, 2020-04-22 at 18:21 -0700, Bart Van Assche wrote:
> On 4/20/20 6:35 PM, Walter Wu wrote:
> > Modify the variable type of 'skip' member of struct stack_trace.
> > In theory, the 'skip' variable type should be unsigned int.
> > There are two reasons:
> > - The 'skip' only has two situation, 1)Positive value, 2)Zero
> > - The 'skip' of struct stack_trace has inconsistent type with struct
> > stack_trace_data, it makes a bit confusion in the relationship between
> > struct stack_trace and stack_trace_data.
>
> Reviewed-by: Bart Van Assche <[email protected]>
Hi Andrew,
Would you know why not to be picked up this patch yet?
Do I miss somethings?
Thank you for your help.
Walter
On Wed, 6 May 2020 10:18:24 +0800 Walter Wu <[email protected]> wrote:
> On Wed, 2020-04-22 at 18:21 -0700, Bart Van Assche wrote:
> > On 4/20/20 6:35 PM, Walter Wu wrote:
> > > Modify the variable type of 'skip' member of struct stack_trace.
> > > In theory, the 'skip' variable type should be unsigned int.
> > > There are two reasons:
> > > - The 'skip' only has two situation, 1)Positive value, 2)Zero
> > > - The 'skip' of struct stack_trace has inconsistent type with struct
> > > stack_trace_data, it makes a bit confusion in the relationship between
> > > struct stack_trace and stack_trace_data.
> >
> > Reviewed-by: Bart Van Assche <[email protected]>
>
> Hi Andrew,
>
> Would you know why not to be picked up this patch yet?
> Do I miss somethings?
I'd decided to pass on this because it's so minor. We inappropriately
use signed types in soooo many places :(