2020-05-06 02:51:19

by Zou Wei

Subject: [PATCH -next] net: ethernet: ti: Use PTR_ERR_OR_ZERO() to simplify code

Fixes coccicheck warning:

drivers/net/ethernet/ti/am65-cpts.c:1017:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Samuel Zou <[email protected]>
---
drivers/net/ethernet/ti/am65-cpts.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c
index 370162c..51c94b2 100644
--- a/drivers/net/ethernet/ti/am65-cpts.c
+++ b/drivers/net/ethernet/ti/am65-cpts.c
@@ -1014,10 +1014,7 @@ static int am65_cpts_probe(struct platform_device *pdev)
return PTR_ERR(base);

cpts = am65_cpts_create(dev, base, node);
- if (IS_ERR(cpts))
- return PTR_ERR(cpts);
-
- return 0;
+ return PTR_ERR_OR_ZERO(cpts);
}

static const struct of_device_id am65_cpts_of_match[] = {
--
2.6.2

2020-05-06 20:48:51

by David Miller

Subject: Re: [PATCH -next] net: ethernet: ti: Use PTR_ERR_OR_ZERO() to simplify code

From: Samuel Zou <[email protected]>
Date: Wed, 6 May 2020 10:54:58 +0800

> Fixes coccicheck warning:
>
> drivers/net/ethernet/ti/am65-cpts.c:1017:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Samuel Zou <[email protected]>

Applied to net-next, thank you.