2020-05-06 03:22:40

by Zou Wei

Subject: [PATCH -next] soundwire: qcom: Use IRQF_ONESHOT

Fixes coccicheck error:

drivers/soundwire/qcom.c:815:7-32: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Samuel Zou <[email protected]>
---
drivers/soundwire/qcom.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index e08a17c..a2a35f7 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -814,7 +814,8 @@ static int qcom_swrm_probe(struct platform_device *pdev)

ret = devm_request_threaded_irq(dev, ctrl->irq, NULL,
qcom_swrm_irq_handler,
- IRQF_TRIGGER_RISING,
+ IRQF_TRIGGER_RISING |
+ IRQF_ONESHOT,
"soundwire", ctrl);
if (ret) {
dev_err(dev, "Failed to request soundwire irq\n");
--
2.6.2

2020-05-11 06:21:33

by Vinod Koul

Subject: Re: [PATCH -next] soundwire: qcom: Use IRQF_ONESHOT

On 06-05-20, 11:25, Samuel Zou wrote:
> Fixes coccicheck error:
>
> drivers/soundwire/qcom.c:815:7-32: ERROR: Threaded IRQ with
> no primary handler requested without IRQF_ONESHOT

Applied, thanks

--
~Vinod