2020-05-07 03:26:43

by Zou Wei

Subject: [PATCH -next] drm/i2c/tda998x: Make tda998x_audio_digital_mute static

Fix the following sparse warning:

drivers/gpu/drm/i2c/tda998x_drv.c:1136:5: warning:
symbol 'tda998x_audio_digital_mute' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Samuel Zou <[email protected]>
---
drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 3c90d7a..9517f52 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1133,7 +1133,8 @@ static void tda998x_audio_shutdown(struct device *dev, void *data)
mutex_unlock(&priv->audio_mutex);
}

-int tda998x_audio_digital_mute(struct device *dev, void *data, bool enable)
+static int tda998x_audio_digital_mute(struct device *dev, void *data,
+ bool enable)
{
struct tda998x_priv *priv = dev_get_drvdata(dev);

--
2.6.2

2020-05-09 21:09:24

by Sam Ravnborg

Subject: Re: [PATCH -next] drm/i2c/tda998x: Make tda998x_audio_digital_mute static

On Thu, May 07, 2020 at 10:49:28AM +0800, Samuel Zou wrote:
> Fix the following sparse warning:
>
> drivers/gpu/drm/i2c/tda998x_drv.c:1136:5: warning:
> symbol 'tda998x_audio_digital_mute' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Samuel Zou <[email protected]>

Thanks.

Pushed to drm-misc-next, so it will appear in next merge window.

Sam

> ---
> drivers/gpu/drm/i2c/tda998x_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
> index 3c90d7a..9517f52 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -1133,7 +1133,8 @@ static void tda998x_audio_shutdown(struct device *dev, void *data)
> mutex_unlock(&priv->audio_mutex);
> }
>
> -int tda998x_audio_digital_mute(struct device *dev, void *data, bool enable)
> +static int tda998x_audio_digital_mute(struct device *dev, void *data,
> + bool enable)
> {
> struct tda998x_priv *priv = dev_get_drvdata(dev);
>
> --
> 2.6.2
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel