2020-05-09 08:25:43

by Anson Huang

[permalink] [raw]
Subject: [PATCH] dt-bindings: reset: Convert i.MX7 reset to json-schema

Convert the i.MX7 reset binding to DT schema format using json-schema.

Signed-off-by: Anson Huang <[email protected]>
---
.../devicetree/bindings/reset/fsl,imx7-src.txt | 56 -------------------
.../devicetree/bindings/reset/fsl,imx7-src.yaml | 64 ++++++++++++++++++++++
2 files changed, 64 insertions(+), 56 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
create mode 100644 Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml

diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
deleted file mode 100644
index e10502d..0000000
--- a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
+++ /dev/null
@@ -1,56 +0,0 @@
-Freescale i.MX7 System Reset Controller
-======================================
-
-Please also refer to reset.txt in this directory for common reset
-controller binding usage.
-
-Required properties:
-- compatible:
- - For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
- - For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
- - For i.MX8MM SoCs should be "fsl,imx8mm-src", "fsl,imx8mq-src", "syscon"
- - For i.MX8MN SoCs should be "fsl,imx8mn-src", "fsl,imx8mq-src", "syscon"
- - For i.MX8MP SoCs should be "fsl,imx8mp-src", "syscon"
-- reg: should be register base and length as documented in the
- datasheet
-- interrupts: Should contain SRC interrupt
-- #reset-cells: 1, see below
-
-example:
-
-src: reset-controller@30390000 {
- compatible = "fsl,imx7d-src", "syscon";
- reg = <0x30390000 0x2000>;
- interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
- #reset-cells = <1>;
-};
-
-
-Specifying reset lines connected to IP modules
-==============================================
-
-The system reset controller can be used to reset various set of
-peripherals. Device nodes that need access to reset lines should
-specify them as a reset phandle in their corresponding node as
-specified in reset.txt.
-
-Example:
-
- pcie: pcie@33800000 {
-
- ...
-
- resets = <&src IMX7_RESET_PCIEPHY>,
- <&src IMX7_RESET_PCIE_CTRL_APPS_EN>;
- reset-names = "pciephy", "apps";
-
- ...
- };
-
-
-For list of all valid reset indices see
-<dt-bindings/reset/imx7-reset.h> for i.MX7,
-<dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ and
-<dt-bindings/reset/imx8mq-reset.h> for i.MX8MM and
-<dt-bindings/reset/imx8mq-reset.h> for i.MX8MN and
-<dt-bindings/reset/imx8mp-reset.h> for i.MX8MP
diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml b/Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml
new file mode 100644
index 0000000..ad254ba
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/fsl,imx7-src.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/reset/fsl,imx7-src.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale i.MX7 System Reset Controller
+
+maintainers:
+ - Anson Huang <[email protected]>
+
+description: |
+ The system reset controller can be used to reset various set of
+ peripherals. Device nodes that need access to reset lines should
+ specify them as a reset phandle in their corresponding node as
+ specified in reset.txt.
+
+ For list of all valid reset indices see
+ <dt-bindings/reset/imx7-reset.h> for i.MX7,
+ <dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ and
+ <dt-bindings/reset/imx8mq-reset.h> for i.MX8MM and
+ <dt-bindings/reset/imx8mq-reset.h> for i.MX8MN and
+ <dt-bindings/reset/imx8mp-reset.h> for i.MX8MP
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - fsl,imx7d-src
+ - fsl,imx8mq-src
+ - fsl,imx8mm-src
+ - fsl,imx8mn-src
+ - fsl,imx8mp-src
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ '#reset-cells':
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - '#reset-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ reset-controller@30390000 {
+ compatible = "fsl,imx7d-src", "syscon";
+ reg = <0x30390000 0x2000>;
+ interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
+ #reset-cells = <1>;
+ };
+
+...
--
2.7.4


2020-05-11 11:18:21

by Aisheng Dong

[permalink] [raw]
Subject: RE: [PATCH] dt-bindings: reset: Convert i.MX7 reset to json-schema

[...]

> +
> +maintainers:
> + - Anson Huang <[email protected]>
> +
> +description: |
> + The system reset controller can be used to reset various set of
> + peripherals. Device nodes that need access to reset lines should
> + specify them as a reset phandle in their corresponding node as
> + specified in reset.txt.
> +
> + For list of all valid reset indices see
> + <dt-bindings/reset/imx7-reset.h> for i.MX7,
> + <dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ and
> + <dt-bindings/reset/imx8mq-reset.h> for i.MX8MM and
> + <dt-bindings/reset/imx8mq-reset.h> for i.MX8MN and

How about combine above three items?

> + <dt-bindings/reset/imx8mp-reset.h> for i.MX8MP
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - fsl,imx7d-src
> + - fsl,imx8mq-src
> + - fsl,imx8mm-src
> + - fsl,imx8mn-src
> + - fsl,imx8mp-src
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + '#reset-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - '#reset-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + reset-controller@30390000 {
> + compatible = "fsl,imx7d-src", "syscon";
> + reg = <0x30390000 0x2000>;
> + interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> + #reset-cells = <1>;
> + };
> +
> +...

Is this required?

Regards
Aisheng

> --
> 2.7.4

2020-05-11 11:32:26

by Anson Huang

[permalink] [raw]
Subject: RE: [PATCH] dt-bindings: reset: Convert i.MX7 reset to json-schema



> Subject: RE: [PATCH] dt-bindings: reset: Convert i.MX7 reset to json-schema
>
> [...]
>
> > +
> > +maintainers:
> > + - Anson Huang <[email protected]>
> > +
> > +description: |
> > + The system reset controller can be used to reset various set of
> > + peripherals. Device nodes that need access to reset lines should
> > + specify them as a reset phandle in their corresponding node as
> > + specified in reset.txt.
> > +
> > + For list of all valid reset indices see
> > + <dt-bindings/reset/imx7-reset.h> for i.MX7,
> > + <dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ and
> > + <dt-bindings/reset/imx8mq-reset.h> for i.MX8MM and
> > + <dt-bindings/reset/imx8mq-reset.h> for i.MX8MN and
>
> How about combine above three items?

Will do.

>
> > + <dt-bindings/reset/imx8mp-reset.h> for i.MX8MP
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - fsl,imx7d-src
> > + - fsl,imx8mq-src
> > + - fsl,imx8mm-src
> > + - fsl,imx8mn-src
> > + - fsl,imx8mp-src
> > + - const: syscon
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + '#reset-cells':
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - '#reset-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + reset-controller@30390000 {
> > + compatible = "fsl,imx7d-src", "syscon";
> > + reg = <0x30390000 0x2000>;
> > + interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> > + #reset-cells = <1>;
> > + };
> > +
> > +...
>
> Is this required?

It can be removed, will remove it in next version.

Anson