2020-05-10 10:15:44

by Matej Dujava

Subject: [PATCH v2 1/2] staging: vt6656: vt6655: clean Makefiles

This patch is removing CFLAGS that are defining flags that are not used.

Signed-off-by: Matej Dujava <[email protected]>
---
drivers/staging/vt6655/Makefile | 3 ---
drivers/staging/vt6655/device_main.c | 1 -
drivers/staging/vt6656/Makefile | 3 ---
3 files changed, 7 deletions(-)

diff --git a/drivers/staging/vt6655/Makefile b/drivers/staging/vt6655/Makefile
index a151f30fc46f..e70357ec0af8 100644
--- a/drivers/staging/vt6655/Makefile
+++ b/drivers/staging/vt6655/Makefile
@@ -1,7 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
-# TODO: all of these should be removed
-ccflags-y := -DLINUX -D__KERNEL__ -D__NO_VERSION__
-ccflags-y += -DHOSTAP

vt6655_stage-y += device_main.o \
card.o \
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 5889023d19c4..41cbec4134b0 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -32,7 +32,6 @@
*
* Revision History:
*/
-#undef __NO_VERSION__

#include <linux/file.h>
#include "device.h"
diff --git a/drivers/staging/vt6656/Makefile b/drivers/staging/vt6656/Makefile
index a0f3862dea75..f696a9d7a143 100644
--- a/drivers/staging/vt6656/Makefile
+++ b/drivers/staging/vt6656/Makefile
@@ -1,7 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
-# TODO: all of these should be removed
-ccflags-y := -DLINUX -D__KERNEL__ -DEXPORT_SYMTAB -D__NO_VERSION__
-ccflags-y += -DHOSTAP

vt6656_stage-y += main_usb.o \
card.o \
--
2.26.2

2020-05-13 11:57:36

by Greg Kroah-Hartman

Subject: Re: [PATCH v2 1/2] staging: vt6656: vt6655: clean Makefiles

On Sun, May 10, 2020 at 12:13:34PM +0200, Matej Dujava wrote:
> This patch is removing CFLAGS that are defining flags that are not used.
>
> Signed-off-by: Matej Dujava <[email protected]>
> ---
> drivers/staging/vt6655/Makefile | 3 ---
> drivers/staging/vt6655/device_main.c | 1 -

This file is not a Makefile :(

Please properly describe patches.

Also state below the --- line what changed from the first version,
otherwise I have no idea.

Please fix up and send a v3 series.

thanks,

greg k-h