2020-05-13 18:28:55

by Nathan Chancellor

Subject: [PATCH] drm/i915: Remove duplicate inline specifier on write_pte

When building with clang:

drivers/gpu/drm/i915/gt/gen8_ppgtt.c:392:24: warning: duplicate
'inline' declaration specifier [-Wduplicate-decl-specifier]
declaration specifier [-Wduplicate-decl-specifier]
static __always_inline inline void
^
include/linux/compiler_types.h:138:16: note: expanded from macro
'inline'
#define inline inline __gnu_inline __inline_maybe_unused notrace
^
1 warning generated.

__always_inline is defined as 'inline __attribute__((__always_inline))'
so we do not need to specify it twice.

Fixes: 84eac0c65940 ("drm/i915/gt: Force pte cacheline to main memory")
Link: https://github.com/ClangBuiltLinux/linux/issues/1024
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
---
drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
index 2dc88e76ebec..699125928272 100644
--- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
+++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
@@ -389,7 +389,7 @@ static int gen8_ppgtt_alloc(struct i915_address_space *vm,
return err;
}

-static __always_inline inline void
+static __always_inline void
write_pte(gen8_pte_t *pte, const gen8_pte_t val)
{
/* Magic delays? Or can we refine these to flush all in one pass? */

base-commit: e098d7762d602be640c53565ceca342f81e55ad2
--
2.26.2

2020-05-13 20:52:52

by Chris Wilson

Subject: Re: [PATCH] drm/i915: Remove duplicate inline specifier on write_pte

Quoting Nathan Chancellor (2020-05-13 19:23:40)
> When building with clang:
>
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c:392:24: warning: duplicate
> 'inline' declaration specifier [-Wduplicate-decl-specifier]
> declaration specifier [-Wduplicate-decl-specifier]
> static __always_inline inline void
> ^
> include/linux/compiler_types.h:138:16: note: expanded from macro
> 'inline'
> #define inline inline __gnu_inline __inline_maybe_unused notrace
> ^
> 1 warning generated.
>
> __always_inline is defined as 'inline __attribute__((__always_inline))'
> so we do not need to specify it twice.
>
> Fixes: 84eac0c65940 ("drm/i915/gt: Force pte cacheline to main memory")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1024
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Nathan Chancellor <[email protected]>

I forgot to ping Mika about this,
Reviewed-by: Chris Wilson <[email protected]>
-Chris