2020-05-15 05:47:49

by jiahao

Subject: [PATCH] xhci: Fix log mistake of xhci_start

It is obvious that XCHI_MAX_HALT_USEC is usec,
not milliseconds; Replace 'milliseconds' with
'usec' of the debug message.

Signed-off-by: jiahao <[email protected]>
---
drivers/usb/host/xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index bee5dec..d011472 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -147,7 +147,7 @@ int xhci_start(struct xhci_hcd *xhci)
STS_HALT, 0, XHCI_MAX_HALT_USEC);
if (ret == -ETIMEDOUT)
xhci_err(xhci, "Host took too long to start, "
- "waited %u microseconds.\n",
+ "waited %u usec.\n",
XHCI_MAX_HALT_USEC);
if (!ret)
/* clear state flags. Including dying, halted or removing */
--
2.7.4

2020-05-15 06:53:14

by Mathias Nyman

Subject: Re: [PATCH] xhci: Fix log mistake of xhci_start

On 15.5.2020 8.45, jiahao wrote:
> It is obvious that XCHI_MAX_HALT_USEC is usec,
> not milliseconds; Replace 'milliseconds' with
> 'usec' of the debug message.
>
> Signed-off-by: jiahao <[email protected]>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index bee5dec..d011472 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -147,7 +147,7 @@ int xhci_start(struct xhci_hcd *xhci)
> STS_HALT, 0, XHCI_MAX_HALT_USEC);
> if (ret == -ETIMEDOUT)
> xhci_err(xhci, "Host took too long to start, "
> - "waited %u microseconds.\n",
> + "waited %u usec.\n",

It already says "microseconds", no need to change it

-Mathias

2020-05-15 09:25:43

by Sergei Shtylyov

Subject: Re: [PATCH] xhci: Fix log mistake of xhci_start

On 15.05.2020 8:45, jiahao wrote:

> It is obvious that XCHI_MAX_HALT_USEC is usec,
> not milliseconds; Replace 'milliseconds' with

I don't see 'milliseconds', only 'microseconds'...

> 'usec' of the debug message.
>
> Signed-off-by: jiahao <[email protected]>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index bee5dec..d011472 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -147,7 +147,7 @@ int xhci_start(struct xhci_hcd *xhci)
> STS_HALT, 0, XHCI_MAX_HALT_USEC);
> if (ret == -ETIMEDOUT)
> xhci_err(xhci, "Host took too long to start, "
> - "waited %u microseconds.\n",
> + "waited %u usec.\n",
> XHCI_MAX_HALT_USEC);
> if (!ret)
> /* clear state flags. Including dying, halted or removing */
>

MBR, Sergei