2020-05-18 07:12:27

by Zhi Li

Subject: [PATCH v2] MIPS: Remove useless parameter of bootcmdline_init()

The parameter "cmdline_p" is useless in bootcmdline_init()，remove it.

Signed-off-by: Zhi Li <[email protected]>
---

v2:
- Remove "the" before "bootcmdline_init()" in the patch subject.

arch/mips/kernel/setup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index 8db533c..7b537fa 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -575,7 +575,7 @@ static int __init bootcmdline_scan_chosen(unsigned long node, const char *uname,

#endif /* CONFIG_OF_EARLY_FLATTREE */

-static void __init bootcmdline_init(char **cmdline_p)
+static void __init bootcmdline_init(void)
{
bool dt_bootargs = false;

@@ -658,7 +658,7 @@ static void __init arch_mem_init(char **cmdline_p)
plat_mem_setup();
memblock_set_bottom_up(true);

- bootcmdline_init(cmdline_p);
+ bootcmdline_init();
strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
*cmdline_p = command_line;

--
2.1.0

2020-05-19 16:34:18

by Thomas Bogendoerfer

Subject: Re: [PATCH v2] MIPS: Remove useless parameter of bootcmdline_init()

On Mon, May 18, 2020 at 03:08:08PM +0800, Zhi Li wrote:
> The parameter "cmdline_p" is useless in bootcmdline_init()，remove it.
>
> Signed-off-by: Zhi Li <[email protected]>

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]