2020-05-19 08:03:21

by Yong Wu (吴勇)

Subject: [PATCH] iommu/mediatek-v1: Fix a build warning for a unused variable 'data'

This patch fixes a build warning:
drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_release_device':
>> drivers/iommu/mtk_iommu_v1.c:467:25: warning: variable 'data' set but
>> not used [-Wunused-but-set-variable]
467 | struct mtk_iommu_data *data;
| ^~~~

It's reported at:
https://lore.kernel.org/linux-iommu/202005191458.gY38V8bU%[email protected]/T/#u

Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Yong Wu <[email protected]>
---
drivers/iommu/mtk_iommu_v1.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c
index f353b07..c9d79cf 100644
--- a/drivers/iommu/mtk_iommu_v1.c
+++ b/drivers/iommu/mtk_iommu_v1.c
@@ -469,12 +469,10 @@ static void mtk_iommu_probe_finalize(struct device *dev)
static void mtk_iommu_release_device(struct device *dev)
{
struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
- struct mtk_iommu_data *data;

if (!fwspec || fwspec->ops != &mtk_iommu_ops)
return;

- data = dev_iommu_priv_get(dev);
iommu_fwspec_free(dev);
}

--
1.9.1

2020-05-19 12:20:53

by Joerg Roedel

Subject: Re: [PATCH] iommu/mediatek-v1: Fix a build warning for a unused variable 'data'

On Tue, May 19, 2020 at 03:57:44PM +0800, Yong Wu wrote:
> This patch fixes a build warning:
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_release_device':
> >> drivers/iommu/mtk_iommu_v1.c:467:25: warning: variable 'data' set but
> >> not used [-Wunused-but-set-variable]
> 467 | struct mtk_iommu_data *data;
> | ^~~~
>
> It's reported at:
> https://lore.kernel.org/linux-iommu/202005191458.gY38V8bU%[email protected]/T/#u
>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Yong Wu <[email protected]>
> ---
> drivers/iommu/mtk_iommu_v1.c | 2 --
> 1 file changed, 2 deletions(-)

Applied, thanks.