2020-05-21 06:40:44

by Sumeet Pawnikar

Subject: [PATCH] powercap: remove unused local MSR define

Remove unused PLATFORM_POWER_LIMIT MSR local definition from file
intel_rapl_common.c. This was missed while splitting old RAPL code
intel_rapl.c file into two new files intel_rapl_msr.c and
intel_rapl_common.c as per the commit 3382388d7148
("intel_rapl: abstract RAPL common code"). Currently, this #define
entry is being used only in intel_rapl_msr.c file and local definition
present in this file.

Signed-off-by: Sumeet Pawnikar <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
---
drivers/powercap/intel_rapl_common.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
index eb328655bc01..5527a7c76309 100644
--- a/drivers/powercap/intel_rapl_common.c
+++ b/drivers/powercap/intel_rapl_common.c
@@ -26,9 +26,6 @@
#include <asm/cpu_device_id.h>
#include <asm/intel-family.h>

-/* Local defines */
-#define MSR_PLATFORM_POWER_LIMIT 0x0000065C
-
/* bitmasks for RAPL MSRs, used by primitive access functions */
#define ENERGY_STATUS_MASK 0xffffffff

--
1.7.9.5

2020-05-25 09:03:51

by Rafael J. Wysocki

Subject: Re: [PATCH] powercap: remove unused local MSR define

On Thu, May 21, 2020 at 8:38 AM Sumeet Pawnikar
<[email protected]> wrote:
>
> Remove unused PLATFORM_POWER_LIMIT MSR local definition from file
> intel_rapl_common.c. This was missed while splitting old RAPL code
> intel_rapl.c file into two new files intel_rapl_msr.c and
> intel_rapl_common.c as per the commit 3382388d7148
> ("intel_rapl: abstract RAPL common code"). Currently, this #define
> entry is being used only in intel_rapl_msr.c file and local definition
> present in this file.
>
> Signed-off-by: Sumeet Pawnikar <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>
> ---
> drivers/powercap/intel_rapl_common.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
> index eb328655bc01..5527a7c76309 100644
> --- a/drivers/powercap/intel_rapl_common.c
> +++ b/drivers/powercap/intel_rapl_common.c
> @@ -26,9 +26,6 @@
> #include <asm/cpu_device_id.h>
> #include <asm/intel-family.h>
>
> -/* Local defines */
> -#define MSR_PLATFORM_POWER_LIMIT 0x0000065C
> -
> /* bitmasks for RAPL MSRs, used by primitive access functions */
> #define ENERGY_STATUS_MASK 0xffffffff
>
> --

Applied as 5.8 material, thanks!