Fix the following gcc warning:
drivers/clk/ti/clk-7xx.c:320:43: warning: ‘dra7_gpu_sys_clk_data’
defined but not used [-Wunused-const-variable=]
static const struct omap_clkctrl_div_data dra7_gpu_sys_clk_data
__initconst = {
^~~~~~~~~~~~~~~~~~~~~
drivers/clk/ti/clk-7xx.c:315:27: warning: ‘dra7_gpu_sys_clk_parents’
defined but not used [-Wunused-const-variable=]
static const char * const dra7_gpu_sys_clk_parents[] __initconst = {
^~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/clk/ti/clk-7xx.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
index 14b645093107..941a67dae22c 100644
--- a/drivers/clk/ti/clk-7xx.c
+++ b/drivers/clk/ti/clk-7xx.c
@@ -312,15 +312,6 @@ static const char * const dra7_gpu_hyd_mux_parents[] __initconst = {
NULL,
};
-static const char * const dra7_gpu_sys_clk_parents[] __initconst = {
- "sys_clkin",
- NULL,
-};
-
-static const struct omap_clkctrl_div_data dra7_gpu_sys_clk_data __initconst = {
- .max_div = 2,
-};
-
static const struct omap_clkctrl_bit_data dra7_gpu_core_bit_data[] __initconst = {
{ 24, TI_CLK_MUX, dra7_gpu_core_mux_parents, NULL, },
{ 26, TI_CLK_MUX, dra7_gpu_hyd_mux_parents, NULL, },
--
2.21.1
Tero,
* Jason Yan <[email protected]> [200417 07:09]:
> Fix the following gcc warning:
>
> drivers/clk/ti/clk-7xx.c:320:43: warning: ‘dra7_gpu_sys_clk_data’
> defined but not used [-Wunused-const-variable=]
> static const struct omap_clkctrl_div_data dra7_gpu_sys_clk_data
> __initconst = {
> ^~~~~~~~~~~~~~~~~~~~~
> drivers/clk/ti/clk-7xx.c:315:27: warning: ‘dra7_gpu_sys_clk_parents’
> defined but not used [-Wunused-const-variable=]
> static const char * const dra7_gpu_sys_clk_parents[] __initconst = {
> ^~~~~~~~~~~~~~~~~~~~~~~~
Looks like this started happening with commit 957ad44ff5f2
("clk: ti: add clkctrl data dra7 sgx") as I did it based on
omap5. But the clocks seem slightly different, care to check
sgx clocking against the TRM in case I also messed up something
else?
Regards,
Tony
* Stephen Boyd <[email protected]> [200514 19:59]:
> Quoting Tony Lindgren (2020-04-17 08:33:42)
> > Tero,
> >
> > * Jason Yan <[email protected]> [200417 07:09]:
> > > Fix the following gcc warning:
> > >
> > > drivers/clk/ti/clk-7xx.c:320:43: warning: \u2018dra7_gpu_sys_clk_data\u2019
> > > defined but not used [-Wunused-const-variable=]
> > > static const struct omap_clkctrl_div_data dra7_gpu_sys_clk_data
> > > __initconst = {
> > > ^~~~~~~~~~~~~~~~~~~~~
> > > drivers/clk/ti/clk-7xx.c:315:27: warning: \u2018dra7_gpu_sys_clk_parents\u2019
> > > defined but not used [-Wunused-const-variable=]
> > > static const char * const dra7_gpu_sys_clk_parents[] __initconst = {
> > > ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Looks like this started happening with commit 957ad44ff5f2
> > ("clk: ti: add clkctrl data dra7 sgx") as I did it based on
> > omap5. But the clocks seem slightly different, care to check
> > sgx clocking against the TRM in case I also messed up something
> > else?
>
> Is that an ack?
Acked-by: Tony Lindgren <[email protected]>
Quoting Tony Lindgren (2020-04-17 08:33:42)
> Tero,
>
> * Jason Yan <[email protected]> [200417 07:09]:
> > Fix the following gcc warning:
> >
> > drivers/clk/ti/clk-7xx.c:320:43: warning: \u2018dra7_gpu_sys_clk_data\u2019
> > defined but not used [-Wunused-const-variable=]
> > static const struct omap_clkctrl_div_data dra7_gpu_sys_clk_data
> > __initconst = {
> > ^~~~~~~~~~~~~~~~~~~~~
> > drivers/clk/ti/clk-7xx.c:315:27: warning: \u2018dra7_gpu_sys_clk_parents\u2019
> > defined but not used [-Wunused-const-variable=]
> > static const char * const dra7_gpu_sys_clk_parents[] __initconst = {
> > ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Looks like this started happening with commit 957ad44ff5f2
> ("clk: ti: add clkctrl data dra7 sgx") as I did it based on
> omap5. But the clocks seem slightly different, care to check
> sgx clocking against the TRM in case I also messed up something
> else?
Is that an ack?
Quoting Jason Yan (2020-04-17 00:35:23)
> Fix the following gcc warning:
>
> drivers/clk/ti/clk-7xx.c:320:43: warning: \u2018dra7_gpu_sys_clk_data\u2019
> defined but not used [-Wunused-const-variable=]
> static const struct omap_clkctrl_div_data dra7_gpu_sys_clk_data
> __initconst = {
> ^~~~~~~~~~~~~~~~~~~~~
> drivers/clk/ti/clk-7xx.c:315:27: warning: \u2018dra7_gpu_sys_clk_parents\u2019
> defined but not used [-Wunused-const-variable=]
> static const char * const dra7_gpu_sys_clk_parents[] __initconst = {
> ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>
> ---
Applied to clk-next