2020-06-11 00:39:55

by Yi Wang

Subject: [PATCH v2] net: atm: Remove the error message according to the atomic context

From: Liao Pingfang <[email protected]>

Looking into the context (atomic!) and the error message should be dropped.

Signed-off-by: Liao Pingfang <[email protected]>
---
Changes in v2: drop the error message instead of changing it.

net/atm/lec.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/atm/lec.c b/net/atm/lec.c
index ca37f5a..997ce13 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -1537,7 +1537,6 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,

to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);
if (!to_return) {
- pr_info("LEC: Arp entry kmalloc failed\n");
return NULL;
}
ether_addr_copy(to_return->mac_addr, mac_addr);
--
2.9.5

2020-06-11 01:13:41

by David Miller

Subject: Re: [PATCH v2] net: atm: Remove the error message according to the atomic context

From: Yi Wang <[email protected]>
Date: Thu, 11 Jun 2020 08:38:50 +0800

> @@ -1537,7 +1537,6 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,
>
> to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);
> if (!to_return) {
> - pr_info("LEC: Arp entry kmalloc failed\n");
> return NULL;
> }

This now becomes a single-statement basic block and thus the curly
braces should be removed.