2020-06-13 06:03:07

by Yi Wang

[permalink] [raw]
Subject: [PATCH v3] net: atm: Remove the error message according to the atomic context

From: Liao Pingfang <[email protected]>

Looking into the context (atomic!) and the error message should be dropped.

Signed-off-by: Liao Pingfang <[email protected]>
---
Changes in v3: remove {} as there is only one statement left.

net/atm/lec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/atm/lec.c b/net/atm/lec.c
index ca37f5a..875fc0b 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -1536,10 +1536,8 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv,
struct lec_arp_table *to_return;

to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC);
- if (!to_return) {
- pr_info("LEC: Arp entry kmalloc failed\n");
+ if (!to_return)
return NULL;
- }
ether_addr_copy(to_return->mac_addr, mac_addr);
INIT_HLIST_NODE(&to_return->next);
timer_setup(&to_return->timer, lec_arp_expire_arp, 0);
--
2.9.5


2020-06-13 22:34:45

by David Miller

[permalink] [raw]
Subject: Re: [PATCH v3] net: atm: Remove the error message according to the atomic context

From: Yi Wang <[email protected]>
Date: Sat, 13 Jun 2020 14:03:26 +0800

> From: Liao Pingfang <[email protected]>
>
> Looking into the context (atomic!) and the error message should be dropped.
>
> Signed-off-by: Liao Pingfang <[email protected]>
> ---
> Changes in v3: remove {} as there is only one statement left.

Applied, thank you.