2020-06-18 03:36:41

by Anson Huang

Subject: [PATCH V4 3/3] dt-bindings: clock: Correct example in i.MX8QXP LPCG binding

In i.MX8QXP LPCG binding's example, "fsl,imx7d-usdhc" as fallback
compatible is incorrect, remove it to avoid below build error:

Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml:
mmc@5b010000: compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected)
Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml:
mmc@5b010000: compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long

Signed-off-by: Anson Huang <[email protected]>
---
New patch, to fix build error when patch #1 is added.
---
Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml b/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml
index 33f3010..1d5e9bc 100644
--- a/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml
+++ b/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml
@@ -62,7 +62,7 @@ examples:
};

mmc@5b010000 {
- compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
+ compatible = "fsl,imx8qxp-usdhc";
interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>;
reg = <0x5b010000 0x10000>;
clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC0_IPG_CLK>,
--
2.7.4

2020-06-29 22:08:51

by Rob Herring (Arm)

Subject: Re: [PATCH V4 3/3] dt-bindings: clock: Correct example in i.MX8QXP LPCG binding

On Thu, Jun 18, 2020 at 11:22:58AM +0800, Anson Huang wrote:
> In i.MX8QXP LPCG binding's example, "fsl,imx7d-usdhc" as fallback
> compatible is incorrect, remove it to avoid below build error:
>
> Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml:
> mmc@5b010000: compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected)
> Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml:
> mmc@5b010000: compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> New patch, to fix build error when patch #1 is added.

So, patch 1 should come last. I'll re-order when applying.

Rob

2020-06-29 22:27:15

by Rob Herring (Arm)

Subject: Re: [PATCH V4 3/3] dt-bindings: clock: Correct example in i.MX8QXP LPCG binding

On Thu, 18 Jun 2020 11:22:58 +0800, Anson Huang wrote:
> In i.MX8QXP LPCG binding's example, "fsl,imx7d-usdhc" as fallback
> compatible is incorrect, remove it to avoid below build error:
>
> Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml:
> mmc@5b010000: compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was unexpected)
> Documentation/devicetree/bindings/clock/imx8qxp-lpcg.example.dt.yaml:
> mmc@5b010000: compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> New patch, to fix build error when patch #1 is added.
> ---
> Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks!