2020-06-09 21:21:06

by Stephen Boyd

Subject: [PATCH] clk: mediatek: Remove ifr{0,1}_cfg_regs structures

These aren't used and the macros that reference them aren't used either.
Remove the dead code to avoid compile warnings.

Cc: Owen Chen <[email protected]>
Cc: Mars Cheng <[email protected]>
Cc: Macpaul Lin <[email protected]>
Fixes: 1aca9939bf72 ("clk: mediatek: Add MT6765 clock support")
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/clk/mediatek/clk-mt6765.c | 30 ------------------------------
1 file changed, 30 deletions(-)

diff --git a/drivers/clk/mediatek/clk-mt6765.c b/drivers/clk/mediatek/clk-mt6765.c
index 3ec53cb62ece..db8db1b3b79d 100644
--- a/drivers/clk/mediatek/clk-mt6765.c
+++ b/drivers/clk/mediatek/clk-mt6765.c
@@ -534,18 +534,6 @@ static const struct mtk_gate top_clks[] = {
GATE_TOP2(CLK_TOP_APLL12_DIV3, "apll12_div3", "aud_1_ck", 5),
};

-static const struct mtk_gate_regs ifr0_cg_regs = {
- .set_ofs = 0x200,
- .clr_ofs = 0x200,
- .sta_ofs = 0x200,
-};
-
-static const struct mtk_gate_regs ifr1_cg_regs = {
- .set_ofs = 0x74,
- .clr_ofs = 0x74,
- .sta_ofs = 0x74,
-};
-
static const struct mtk_gate_regs ifr2_cg_regs = {
.set_ofs = 0x80,
.clr_ofs = 0x84,
@@ -570,24 +558,6 @@ static const struct mtk_gate_regs ifr5_cg_regs = {
.sta_ofs = 0xc8,
};

-#define GATE_IFR0(_id, _name, _parent, _shift) { \
- .id = _id, \
- .name = _name, \
- .parent_name = _parent, \
- .regs = &ifr0_cg_regs, \
- .shift = _shift, \
- .ops = &mtk_clk_gate_ops_no_setclr_inv, \
- }
-
-#define GATE_IFR1(_id, _name, _parent, _shift) { \
- .id = _id, \
- .name = _name, \
- .parent_name = _parent, \
- .regs = &ifr1_cg_regs, \
- .shift = _shift, \
- .ops = &mtk_clk_gate_ops_no_setclr, \
- }
-
#define GATE_IFR2(_id, _name, _parent, _shift) { \
.id = _id, \
.name = _name, \
--
Sent by a computer, using git, on the internet

2020-06-18 10:47:30

by Macpaul Lin

Subject: Re: [PATCH] clk: mediatek: Remove ifr{0,1}_cfg_regs structures

On Tue, 2020-06-09 at 14:18 -0700, Stephen Boyd wrote:
> These aren't used and the macros that reference them aren't used either.
> Remove the dead code to avoid compile warnings.
>
> Cc: Owen Chen <[email protected]>
> Cc: Mars Cheng <[email protected]>
> Cc: Macpaul Lin <[email protected]>
> Fixes: 1aca9939bf72 ("clk: mediatek: Add MT6765 clock support")
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
> drivers/clk/mediatek/clk-mt6765.c | 30 ------------------------------
> 1 file changed, 30 deletions(-)
>
> diff --git a/drivers/clk/mediatek/clk-mt6765.c b/drivers/clk/mediatek/clk-mt6765.c
> index 3ec53cb62ece..db8db1b3b79d 100644
> --- a/drivers/clk/mediatek/clk-mt6765.c
> +++ b/drivers/clk/mediatek/clk-mt6765.c
> @@ -534,18 +534,6 @@ static const struct mtk_gate top_clks[] = {
> GATE_TOP2(CLK_TOP_APLL12_DIV3, "apll12_div3", "aud_1_ck", 5),
> };
>
> -static const struct mtk_gate_regs ifr0_cg_regs = {
> - .set_ofs = 0x200,
> - .clr_ofs = 0x200,
> - .sta_ofs = 0x200,
> -};
> -
> -static const struct mtk_gate_regs ifr1_cg_regs = {
> - .set_ofs = 0x74,
> - .clr_ofs = 0x74,
> - .sta_ofs = 0x74,
> -};
> -
> static const struct mtk_gate_regs ifr2_cg_regs = {
> .set_ofs = 0x80,
> .clr_ofs = 0x84,
> @@ -570,24 +558,6 @@ static const struct mtk_gate_regs ifr5_cg_regs = {
> .sta_ofs = 0xc8,
> };
>
> -#define GATE_IFR0(_id, _name, _parent, _shift) { \
> - .id = _id, \
> - .name = _name, \
> - .parent_name = _parent, \
> - .regs = &ifr0_cg_regs, \
> - .shift = _shift, \
> - .ops = &mtk_clk_gate_ops_no_setclr_inv, \
> - }
> -
> -#define GATE_IFR1(_id, _name, _parent, _shift) { \
> - .id = _id, \
> - .name = _name, \
> - .parent_name = _parent, \
> - .regs = &ifr1_cg_regs, \
> - .shift = _shift, \
> - .ops = &mtk_clk_gate_ops_no_setclr, \
> - }
> -
> #define GATE_IFR2(_id, _name, _parent, _shift) { \
> .id = _id, \
> .name = _name, \

Thank you so much!
Owen and I were busy in other issues hence cannot help fix this issue
in time.

Thanks a lot!
BR,
Macpaul Lin