The audio codec on the GW551x routes to ssi1
Signed-off-by: Tim Harvey <[email protected]>
---
v2: fix typo in commit short desc
---
arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
index c38e86e..8c33510 100644
--- a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
@@ -110,7 +110,7 @@
simple-audio-card,frame-master = <&sound_codec>;
sound_cpu: simple-audio-card,cpu {
- sound-dai = <&ssi2>;
+ sound-dai = <&ssi1>;
};
sound_codec: simple-audio-card,codec {
--
2.7.4
Hi Tim,
On Tue, Jun 23, 2020 at 3:31 PM Tim Harvey <[email protected]> wrote:
>
> The audio codec on the GW551x routes to ssi1
>
> Signed-off-by: Tim Harvey <[email protected]>
Shouldn't this have a Fixes tag, so that it could be backported to
older stable kernels?
On Tue, Jun 23, 2020 at 11:41 AM Fabio Estevam <[email protected]> wrote:
>
> Hi Tim,
>
> On Tue, Jun 23, 2020 at 3:31 PM Tim Harvey <[email protected]> wrote:
> >
> > The audio codec on the GW551x routes to ssi1
> >
> > Signed-off-by: Tim Harvey <[email protected]>
>
> Shouldn't this have a Fixes tag, so that it could be backported to
> older stable kernels?
Fabio,
Yes, it likely should as it fixes audio capture from 3117e851cef1b4e1.
I didn't think it would apply cleanly to stable but it looks like it
does.
I cc'd [email protected]. Should I submit a new revision with the
following?
Cc: [email protected]
Fixes: 3117e851cef1b4e1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x")
Thanks,
Tim
Hi Tim,
On Tue, Jun 23, 2020 at 3:52 PM Tim Harvey <[email protected]> wrote:
> Yes, it likely should as it fixes audio capture from 3117e851cef1b4e1.
> I didn't think it would apply cleanly to stable but it looks like it
> does.
>
> I cc'd [email protected]. Should I submit a new revision with the
> following?
>
> Cc: [email protected]
> Fixes: 3117e851cef1b4e1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x")
Yes, that would be better.
Please note that the commit ID used in the Fixes tag should be 12-digit long.
The audio codec on the GW551x routes to ssi1
Cc: [email protected]
Fixes: 3117e851cef1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x")
Signed-off-by: Tim Harvey <[email protected]>
---
v3: add fixes tag
v2: fix typo in commit short desc
---
arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
index c38e86e..8c33510 100644
--- a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
@@ -110,7 +110,7 @@
simple-audio-card,frame-master = <&sound_codec>;
sound_cpu: simple-audio-card,cpu {
- sound-dai = <&ssi2>;
+ sound-dai = <&ssi1>;
};
sound_codec: simple-audio-card,codec {
--
2.7.4
On Tue, Jun 23, 2020 at 4:07 PM Tim Harvey <[email protected]> wrote:
>
> The audio codec on the GW551x routes to ssi1
>
> Cc: [email protected]
> Fixes: 3117e851cef1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x")
> Signed-off-by: Tim Harvey <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
On Tue, Jun 23, 2020 at 12:06:54PM -0700, Tim Harvey wrote:
> The audio codec on the GW551x routes to ssi1
>
> Cc: [email protected]
> Fixes: 3117e851cef1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x")
> Signed-off-by: Tim Harvey <[email protected]>
Applied, thanks.