2020-07-05 19:35:54

by Kanchan Joshi

[permalink] [raw]
Subject: [PATCH v2] block: fix error code for zone-append

Avoid returning success when max_append_sectors is zero. This prevents
infinite loop in bio_iov_iter_get_pages().

Signed-off-by: Kanchan Joshi <[email protected]>
Signed-off-by: Selvakumar S <[email protected]>
Signed-off-by: Nitesh Shetty <[email protected]>
Signed-off-by: Javier Gonzalez <[email protected]>
Reviewed-by: Damien Le Moal <[email protected]>
---
block/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/bio.c b/block/bio.c
index a7366c0..0cecdbc 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1044,7 +1044,7 @@ static int __bio_iov_append_get_pages(struct bio *bio, struct iov_iter *iter)
size_t offset;

if (WARN_ON_ONCE(!max_append_sectors))
- return 0;
+ return -EINVAL;

/*
* Move page array up in the allocated memory for the bio vecs as far as
--
2.7.4