2020-07-10 08:23:24

by Akash Asthana

Subject: [PATCH] of: Add stub for of_get_next_parent

Fixes compilation error reported on x86 platform:

drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of
function 'of_get_next_parent'.

drivers/soc/qcom/qcom-geni-se.c:819:9: warning: incompatible integer to
pointer conversion assigning to 'struct device_node *' from 'int'

Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix
earlycon crash")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Akash Asthana <[email protected]>
---
include/linux/of.h | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index c669c0a..72e7198 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -630,6 +630,12 @@ static inline struct device_node *of_get_parent(const struct device_node *node)
return NULL;
}

+static inline struct device_node *of_get_next_parent(
+ const struct device_node *node)
+{
+ return NULL;
+}
+
static inline struct device_node *of_get_next_child(
const struct device_node *node, struct device_node *prev)
{
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project

2020-07-10 15:31:05

by Rob Herring

Subject: Re: [PATCH] of: Add stub for of_get_next_parent

On Fri, Jul 10, 2020 at 2:19 AM Akash Asthana <[email protected]> wrote:
>
> Fixes compilation error reported on x86 platform:
>
> drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of
> function 'of_get_next_parent'.
>
> drivers/soc/qcom/qcom-geni-se.c:819:9: warning: incompatible integer to
> pointer conversion assigning to 'struct device_node *' from 'int'
>
> Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix
> earlycon crash")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Akash Asthana <[email protected]>
> ---
> include/linux/of.h | 6 ++++++
> 1 file changed, 6 insertions(+)

Already have a similar patch.