2020-07-14 10:59:21

by Yi Wang

[permalink] [raw]
Subject: [PATCH] scsi: imm: Remove superfluous breaks

From: Liao Pingfang <[email protected]>

Remove superfluous breaks, as there is a "return" before them.

Signed-off-by: Liao Pingfang <[email protected]>
Signed-off-by: Yi Wang <[email protected]>
---
drivers/scsi/imm.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c
index 2519fb7..1459b14 100644
--- a/drivers/scsi/imm.c
+++ b/drivers/scsi/imm.c
@@ -903,7 +903,6 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
w_ctr(ppb, 0x4);
}
return 0; /* Finished */
- break;

default:
printk("imm: Invalid scsi phase\n");
@@ -969,10 +968,8 @@ static int imm_abort(struct scsi_cmnd *cmd)
case 1: /* Have not connected to interface */
dev->cur_cmd = NULL; /* Forget the problem */
return SUCCESS;
- break;
default: /* SCSI command sent, can not abort */
return FAILED;
- break;
}
}

--
2.9.5


2020-07-25 02:53:35

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: imm: Remove superfluous breaks

On Tue, 14 Jul 2020 18:59:27 +0800, Yi Wang wrote:

> Remove superfluous breaks, as there is a "return" before them.

Applied to 5.9/scsi-queue, thanks!

[1/1] scsi: imm: Remove superfluous breaks
https://git.kernel.org/mkp/scsi/c/b54dc46cbe71

--
Martin K. Petersen Oracle Linux Engineering