2020-07-14 10:57:49

by Yi Wang

Subject: [PATCH] scsi: ppa: Remove superfluous breaks

From: Liao Pingfang <[email protected]>

Remove superfluous breaks, as there is a "return" before them.

Signed-off-by: Liao Pingfang <[email protected]>
Signed-off-by: Yi Wang <[email protected]>
---
drivers/scsi/ppa.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/ppa.c b/drivers/scsi/ppa.c
index a406cc8..0ae800c 100644
--- a/drivers/scsi/ppa.c
+++ b/drivers/scsi/ppa.c
@@ -779,7 +779,6 @@ static int ppa_engine(ppa_struct *dev, struct scsi_cmnd *cmd)
(DID_OK << 16) + (h << 8) + (l & STATUS_MASK);
}
return 0; /* Finished */
- break;

default:
printk(KERN_ERR "ppa: Invalid scsi phase\n");
@@ -847,10 +846,8 @@ static int ppa_abort(struct scsi_cmnd *cmd)
case 1: /* Have not connected to interface */
dev->cur_cmd = NULL; /* Forget the problem */
return SUCCESS;
- break;
default: /* SCSI command sent, can not abort */
return FAILED;
- break;
}
}

--
2.9.5

2020-07-25 02:53:53

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ppa: Remove superfluous breaks

On Tue, 14 Jul 2020 18:59:31 +0800, Yi Wang wrote:

> Remove superfluous breaks, as there is a "return" before them.

Applied to 5.9/scsi-queue, thanks!

[1/1] scsi: ppa: Remove superfluous breaks
https://git.kernel.org/mkp/scsi/c/6671eebd672c

--
Martin K. Petersen Oracle Linux Engineering