2020-07-14 15:07:25

by Sivaprakash Murugesan

[permalink] [raw]
Subject: [PATCH 0/4] Split ipq8074 reset bindings from clock bindings

The patch series https://lwn.net/Articles/825325/ wrongly added clock
bindings into reset bindings. This is caught by
kernel test robot <[email protected]> after it got merged into the clk-next
tree.

To avoid these kind of future mistakes it is better we split up the reset
bindings from clock bindings.

Since the clock patches in https://lwn.net/Articles/825325/ are applied to
clk-next it would be better if all the changes in this series to go through
clk-next.

Sivaprakash Murugesan (4):
clk: qcom: ipq8074: remove gcc reset bindings
reset: qcom: ipq8074: Add ipq8074 gcc resets
arm64: dts: ipq8074: include reset bindings
clk: qcom: ipq8074: include gcc reset bindings

arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
drivers/clk/qcom/gcc-ipq8074.c | 1 +
include/dt-bindings/clock/qcom,gcc-ipq8074.h | 139 +-------------------------
include/dt-bindings/reset/qcom,gcc-ipq8074.h | 141 +++++++++++++++++++++++++++
4 files changed, 146 insertions(+), 136 deletions(-)
create mode 100644 include/dt-bindings/reset/qcom,gcc-ipq8074.h

--
2.7.4


2020-07-14 15:09:30

by Sivaprakash Murugesan

[permalink] [raw]
Subject: [PATCH 3/4] arm64: dts: ipq8074: include reset bindings

Include gcc reset bindings in ipq8074 device tree

Signed-off-by: Sivaprakash Murugesan <[email protected]>
---
arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index 5303821300b4..be2690c31433 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -5,6 +5,7 @@

#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/qcom,gcc-ipq8074.h>
+#include <dt-bindings/reset/qcom,gcc-ipq8074.h>

/ {
model = "Qualcomm Technologies, Inc. IPQ8074";
--
2.7.4

2020-07-16 00:57:48

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH 0/4] Split ipq8074 reset bindings from clock bindings

Quoting Sivaprakash Murugesan (2020-07-14 08:05:18)
> The patch series https://lwn.net/Articles/825325/ wrongly added clock
> bindings into reset bindings. This is caught by
> kernel test robot <[email protected]> after it got merged into the clk-next
> tree.
>
> To avoid these kind of future mistakes it is better we split up the reset
> bindings from clock bindings.
>
> Since the clock patches in https://lwn.net/Articles/825325/ are applied to
> clk-next it would be better if all the changes in this series to go through
> clk-next.

I disagree. We've put them all in the same file because they're all used
provided by the same compatible string. Please keep doing that and just
fix the number scheme if that is the problem. Also, use lore.kernel.org
for your links next time (i.e. https://lore.kernel.org/r/<message-id>)
so that we don't need to rely on lwn.net links.