2020-07-16 11:36:40

by Kalyan Thota

Subject: [PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target

From: Krishna Manikandan <[email protected]>

Move the bus clock to mdp device node,in order
to facilitate bus band width scaling on sc7180
target.

The parent device MDSS will not vote for bus bw,
instead the vote will be triggered by mdp device
node. Since a minimum vote is required to turn
on bus clock, move the clock node to mdp device
from where the votes are requested.

This patch has dependency on the below series
https://patchwork.kernel.org/patch/11468783/

Signed-off-by: Krishna Manikandan <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 4f2c0d1..31fed6d 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1510,10 +1510,9 @@
power-domains = <&dispcc MDSS_GDSC>;

clocks = <&gcc GCC_DISP_AHB_CLK>,
- <&gcc GCC_DISP_HF_AXI_CLK>,
<&dispcc DISP_CC_MDSS_AHB_CLK>,
<&dispcc DISP_CC_MDSS_MDP_CLK>;
- clock-names = "iface", "bus", "ahb", "core";
+ clock-names = "iface", "ahb", "core";

assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
assigned-clock-rates = <300000000>;
@@ -1539,12 +1538,13 @@
<0 0x0aeb0000 0 0x2008>;
reg-names = "mdp", "vbif";

- clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
+ <&dispcc DISP_CC_MDSS_AHB_CLK>,
<&dispcc DISP_CC_MDSS_ROT_CLK>,
<&dispcc DISP_CC_MDSS_MDP_LUT_CLK>,
<&dispcc DISP_CC_MDSS_MDP_CLK>,
<&dispcc DISP_CC_MDSS_VSYNC_CLK>;
- clock-names = "iface", "rot", "lut", "core",
+ clock-names = "bus", "iface", "rot", "lut", "core",
"vsync";
assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
<&dispcc DISP_CC_MDSS_VSYNC_CLK>;
--
1.9.1

2020-08-04 15:43:52

by Rob Clark

Subject: Re: [PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target

On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota <[email protected]> wrote:
>
> From: Krishna Manikandan <[email protected]>
>
> Move the bus clock to mdp device node,in order
> to facilitate bus band width scaling on sc7180
> target.
>
> The parent device MDSS will not vote for bus bw,
> instead the vote will be triggered by mdp device
> node. Since a minimum vote is required to turn
> on bus clock, move the clock node to mdp device
> from where the votes are requested.
>
> This patch has dependency on the below series
> https://patchwork.kernel.org/patch/11468783/
>
> Signed-off-by: Krishna Manikandan <[email protected]>

Reviewed-by: Rob Clark <[email protected]>

> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 4f2c0d1..31fed6d 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1510,10 +1510,9 @@
> power-domains = <&dispcc MDSS_GDSC>;
>
> clocks = <&gcc GCC_DISP_AHB_CLK>,
> - <&gcc GCC_DISP_HF_AXI_CLK>,
> <&dispcc DISP_CC_MDSS_AHB_CLK>,
> <&dispcc DISP_CC_MDSS_MDP_CLK>;
> - clock-names = "iface", "bus", "ahb", "core";
> + clock-names = "iface", "ahb", "core";
>
> assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
> assigned-clock-rates = <300000000>;
> @@ -1539,12 +1538,13 @@
> <0 0x0aeb0000 0 0x2008>;
> reg-names = "mdp", "vbif";
>
> - clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> + clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
> + <&dispcc DISP_CC_MDSS_AHB_CLK>,
> <&dispcc DISP_CC_MDSS_ROT_CLK>,
> <&dispcc DISP_CC_MDSS_MDP_LUT_CLK>,
> <&dispcc DISP_CC_MDSS_MDP_CLK>,
> <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> - clock-names = "iface", "rot", "lut", "core",
> + clock-names = "bus", "iface", "rot", "lut", "core",
> "vsync";
> assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
> <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> --
> 1.9.1
>

2020-09-10 22:03:40

by Bjorn Andersson

Subject: Re: [PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target

On Thu 16 Jul 11:35 UTC 2020, Kalyan Thota wrote:

> From: Krishna Manikandan <[email protected]>
>
> Move the bus clock to mdp device node,in order
> to facilitate bus band width scaling on sc7180
> target.
>
> The parent device MDSS will not vote for bus bw,
> instead the vote will be triggered by mdp device
> node. Since a minimum vote is required to turn
> on bus clock, move the clock node to mdp device
> from where the votes are requested.
>
> This patch has dependency on the below series
> https://patchwork.kernel.org/patch/11468783/
>

Isn't this dependency on an old revision of patch 3/3 in this series?

Regardless, I don't see either the linked patch or patch 3 merged in
linux-next, so I presume I should not merge this?

Regards,
Bjorn

> Signed-off-by: Krishna Manikandan <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 4f2c0d1..31fed6d 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1510,10 +1510,9 @@
> power-domains = <&dispcc MDSS_GDSC>;
>
> clocks = <&gcc GCC_DISP_AHB_CLK>,
> - <&gcc GCC_DISP_HF_AXI_CLK>,
> <&dispcc DISP_CC_MDSS_AHB_CLK>,
> <&dispcc DISP_CC_MDSS_MDP_CLK>;
> - clock-names = "iface", "bus", "ahb", "core";
> + clock-names = "iface", "ahb", "core";
>
> assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
> assigned-clock-rates = <300000000>;
> @@ -1539,12 +1538,13 @@
> <0 0x0aeb0000 0 0x2008>;
> reg-names = "mdp", "vbif";
>
> - clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> + clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
> + <&dispcc DISP_CC_MDSS_AHB_CLK>,
> <&dispcc DISP_CC_MDSS_ROT_CLK>,
> <&dispcc DISP_CC_MDSS_MDP_LUT_CLK>,
> <&dispcc DISP_CC_MDSS_MDP_CLK>,
> <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> - clock-names = "iface", "rot", "lut", "core",
> + clock-names = "bus", "iface", "rot", "lut", "core",
> "vsync";
> assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
> <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> --
> 1.9.1
>

2020-09-10 22:04:55

by Rob Clark

Subject: Re: [PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target

On Thu, Sep 10, 2020 at 3:00 PM Bjorn Andersson
<[email protected]> wrote:
>
> On Thu 16 Jul 11:35 UTC 2020, Kalyan Thota wrote:
>
> > From: Krishna Manikandan <[email protected]>
> >
> > Move the bus clock to mdp device node,in order
> > to facilitate bus band width scaling on sc7180
> > target.
> >
> > The parent device MDSS will not vote for bus bw,
> > instead the vote will be triggered by mdp device
> > node. Since a minimum vote is required to turn
> > on bus clock, move the clock node to mdp device
> > from where the votes are requested.
> >
> > This patch has dependency on the below series
> > https://patchwork.kernel.org/patch/11468783/
> >
>
> Isn't this dependency on an old revision of patch 3/3 in this series?
>
> Regardless, I don't see either the linked patch or patch 3 merged in
> linux-next, so I presume I should not merge this?

I guess that would be "drm/msm/dpu: add support for clk and bw scaling
for display" on msm-next-staging[1] (about to be msm-next)

[1] https://gitlab.freedesktop.org/drm/msm/-/commits/msm-next-staging


> Regards,
> Bjorn
>
> > Signed-off-by: Krishna Manikandan <[email protected]>
> > ---
> > arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > index 4f2c0d1..31fed6d 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > @@ -1510,10 +1510,9 @@
> > power-domains = <&dispcc MDSS_GDSC>;
> >
> > clocks = <&gcc GCC_DISP_AHB_CLK>,
> > - <&gcc GCC_DISP_HF_AXI_CLK>,
> > <&dispcc DISP_CC_MDSS_AHB_CLK>,
> > <&dispcc DISP_CC_MDSS_MDP_CLK>;
> > - clock-names = "iface", "bus", "ahb", "core";
> > + clock-names = "iface", "ahb", "core";
> >
> > assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
> > assigned-clock-rates = <300000000>;
> > @@ -1539,12 +1538,13 @@
> > <0 0x0aeb0000 0 0x2008>;
> > reg-names = "mdp", "vbif";
> >
> > - clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> > + clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
> > + <&dispcc DISP_CC_MDSS_AHB_CLK>,
> > <&dispcc DISP_CC_MDSS_ROT_CLK>,
> > <&dispcc DISP_CC_MDSS_MDP_LUT_CLK>,
> > <&dispcc DISP_CC_MDSS_MDP_CLK>,
> > <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> > - clock-names = "iface", "rot", "lut", "core",
> > + clock-names = "bus", "iface", "rot", "lut", "core",
> > "vsync";
> > assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>,
> > <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
> > --
> > 1.9.1
> >