2020-07-17 08:07:31

by Xiongfeng Wang

Subject: [PATCH] PCI/ASPM: add missing newline when printing parameter 'policy' by sysfs

When I cat ASPM parameter 'policy' by sysfs, it displays as follows.
It's better to add a newline for easy reading.

[root@localhost ~]# cat /sys/module/pcie_aspm/parameters/policy
[default] performance powersave powersupersave [root@localhost ~]#

Signed-off-by: Xiongfeng Wang <[email protected]>
---
drivers/pci/pcie/aspm.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
index b17e5ff..253c30c 100644
--- a/drivers/pci/pcie/aspm.c
+++ b/drivers/pci/pcie/aspm.c
@@ -1182,6 +1182,7 @@ static int pcie_aspm_get_policy(char *buffer, const struct kernel_param *kp)
cnt += sprintf(buffer + cnt, "[%s] ", policy_str[i]);
else
cnt += sprintf(buffer + cnt, "%s ", policy_str[i]);
+ cnt += sprintf(buffer + cnt, "\n");
return cnt;
}

--
1.7.12.4

2020-07-17 21:39:23

by Bjorn Helgaas

Subject: Re: [PATCH] PCI/ASPM: add missing newline when printing parameter 'policy' by sysfs

On Fri, Jul 17, 2020 at 03:59:25PM +0800, Xiongfeng Wang wrote:
> When I cat ASPM parameter 'policy' by sysfs, it displays as follows.
> It's better to add a newline for easy reading.
>
> [root@localhost ~]# cat /sys/module/pcie_aspm/parameters/policy
> [default] performance powersave powersupersave [root@localhost ~]#
>
> Signed-off-by: Xiongfeng Wang <[email protected]>

Applied to pci/aspm for v5.9, thanks!

> ---
> drivers/pci/pcie/aspm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index b17e5ff..253c30c 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -1182,6 +1182,7 @@ static int pcie_aspm_get_policy(char *buffer, const struct kernel_param *kp)
> cnt += sprintf(buffer + cnt, "[%s] ", policy_str[i]);
> else
> cnt += sprintf(buffer + cnt, "%s ", policy_str[i]);
> + cnt += sprintf(buffer + cnt, "\n");
> return cnt;
> }
>
> --
> 1.7.12.4
>