remove the redundant clk interface of uart.
CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.
Change since v2:
Commit "dt-bindings: clock: remove UART3 clock support"
-- remove Fixes tag
Commit "clk: mediatek: remove UART3 clock support"
-- remove Fixes tag
Hanks Chen (2):
dt-bindings: clock: remove UART3 clock support
clk: mediatek: remove UART3 clock support
drivers/clk/mediatek/clk-mt6779.c | 2 --
include/dt-bindings/clock/mt6779-clk.h | 1 -
2 files changed, 3 deletions(-)
--
2.18.0
CLK_INFRA_UART3 is a dummy clk interface,
it has no effect on the operation of the read/write instruction.
Signed-off-by: Hanks Chen <[email protected]>
---
drivers/clk/mediatek/clk-mt6779.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/clk/mediatek/clk-mt6779.c b/drivers/clk/mediatek/clk-mt6779.c
index 9766cccf5844..75f2235486be 100644
--- a/drivers/clk/mediatek/clk-mt6779.c
+++ b/drivers/clk/mediatek/clk-mt6779.c
@@ -923,8 +923,6 @@ static const struct mtk_gate infra_clks[] = {
"uart_sel", 23),
GATE_INFRA0(CLK_INFRA_UART2, "infra_uart2",
"uart_sel", 24),
- GATE_INFRA0(CLK_INFRA_UART3, "infra_uart3",
- "uart_sel", 25),
GATE_INFRA0(CLK_INFRA_GCE_26M, "infra_gce_26m",
"axi_sel", 27),
GATE_INFRA0(CLK_INFRA_CQ_DMA_FPC, "infra_cqdma_fpc",
--
2.18.0
remove the redundant clk interface of uart.
Signed-off-by: Hanks Chen <[email protected]>
---
include/dt-bindings/clock/mt6779-clk.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/dt-bindings/clock/mt6779-clk.h b/include/dt-bindings/clock/mt6779-clk.h
index b083139afbd2..2b5f2354d7eb 100644
--- a/include/dt-bindings/clock/mt6779-clk.h
+++ b/include/dt-bindings/clock/mt6779-clk.h
@@ -229,7 +229,6 @@
#define CLK_INFRA_UART0 21
#define CLK_INFRA_UART1 22
#define CLK_INFRA_UART2 23
-#define CLK_INFRA_UART3 24
#define CLK_INFRA_GCE_26M 25
#define CLK_INFRA_CQ_DMA_FPC 26
#define CLK_INFRA_BTIF 27
--
2.18.0
On 22/07/2020 05:09, Hanks Chen wrote:
> remove the redundant clk interface of uart.
> CLK_INFRA_UART3 is a dummy clk interface,
> it has no effect on the operation of the read/write instruction.
>
> Change since v2:
> Commit "dt-bindings: clock: remove UART3 clock support"
Sorry just another comment. I think we can make this one patch deleting everything.
> -- remove Fixes tag
> Commit "clk: mediatek: remove UART3 clock support"
> -- remove Fixes tag
>
> Hanks Chen (2):
> dt-bindings: clock: remove UART3 clock support
> clk: mediatek: remove UART3 clock support
>
> drivers/clk/mediatek/clk-mt6779.c | 2 --
> include/dt-bindings/clock/mt6779-clk.h | 1 -
> 2 files changed, 3 deletions(-)
>
On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote:
>
> On 22/07/2020 05:09, Hanks Chen wrote:
> > remove the redundant clk interface of uart.
> > CLK_INFRA_UART3 is a dummy clk interface,
> > it has no effect on the operation of the read/write instruction.
> >
> > Change since v2:
> > Commit "dt-bindings: clock: remove UART3 clock support"
>
> Sorry just another comment. I think we can make this one patch deleting everything.
>
Sorry, I don't understand the comment. Do I need to merge them into one
big patch?
Btw, if I use one patch, I would get check patch fail.
---
[2020-07-22 19:12:49,046 ERROR] Run check patch results:
WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a
separate patch. See:
Documentation/devicetree/bindings/submitting-patches.rst
---
Hanks
> > -- remove Fixes tag
> > Commit "clk: mediatek: remove UART3 clock support"
> > -- remove Fixes tag
> >
> > Hanks Chen (2):
> > dt-bindings: clock: remove UART3 clock support
> > clk: mediatek: remove UART3 clock support
> >
> > drivers/clk/mediatek/clk-mt6779.c | 2 --
> > include/dt-bindings/clock/mt6779-clk.h | 1 -
> > 2 files changed, 3 deletions(-)
> >
On 22/07/2020 13:16, Hanks Chen wrote:
> On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote:
>>
>> On 22/07/2020 05:09, Hanks Chen wrote:
>>> remove the redundant clk interface of uart.
>>> CLK_INFRA_UART3 is a dummy clk interface,
>>> it has no effect on the operation of the read/write instruction.
>>>
>>> Change since v2:
>>> Commit "dt-bindings: clock: remove UART3 clock support"
>>
>> Sorry just another comment. I think we can make this one patch deleting everything.
>>
> Sorry, I don't understand the comment. Do I need to merge them into one
> big patch?
> Btw, if I use one patch, I would get check patch fail.
> ---
> [2020-07-22 19:12:49,046 ERROR] Run check patch results:
> WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a
> separate patch. See:
> Documentation/devicetree/bindings/submitting-patches.rst
> ---
Hm, I think that's a debatable error message from checkpatch, but let's leave it
as it is.
Regards,
Matthias
>
> Hanks
>
>>> -- remove Fixes tag
>>> Commit "clk: mediatek: remove UART3 clock support"
>>> -- remove Fixes tag
>>>
>>> Hanks Chen (2):
>>> dt-bindings: clock: remove UART3 clock support
>>> clk: mediatek: remove UART3 clock support
>>>
>>> drivers/clk/mediatek/clk-mt6779.c | 2 --
>>> include/dt-bindings/clock/mt6779-clk.h | 1 -
>>> 2 files changed, 3 deletions(-)
>>>
>
On 22/07/2020 05:09, Hanks Chen wrote:
> remove the redundant clk interface of uart.
>
> Signed-off-by: Hanks Chen <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]>
> ---
> include/dt-bindings/clock/mt6779-clk.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/mt6779-clk.h b/include/dt-bindings/clock/mt6779-clk.h
> index b083139afbd2..2b5f2354d7eb 100644
> --- a/include/dt-bindings/clock/mt6779-clk.h
> +++ b/include/dt-bindings/clock/mt6779-clk.h
> @@ -229,7 +229,6 @@
> #define CLK_INFRA_UART0 21
> #define CLK_INFRA_UART1 22
> #define CLK_INFRA_UART2 23
> -#define CLK_INFRA_UART3 24
> #define CLK_INFRA_GCE_26M 25
> #define CLK_INFRA_CQ_DMA_FPC 26
> #define CLK_INFRA_BTIF 27
>
On 22/07/2020 05:09, Hanks Chen wrote:
> CLK_INFRA_UART3 is a dummy clk interface,
> it has no effect on the operation of the read/write instruction.
>
> Signed-off-by: Hanks Chen <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]>
> ---
> drivers/clk/mediatek/clk-mt6779.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/mediatek/clk-mt6779.c b/drivers/clk/mediatek/clk-mt6779.c
> index 9766cccf5844..75f2235486be 100644
> --- a/drivers/clk/mediatek/clk-mt6779.c
> +++ b/drivers/clk/mediatek/clk-mt6779.c
> @@ -923,8 +923,6 @@ static const struct mtk_gate infra_clks[] = {
> "uart_sel", 23),
> GATE_INFRA0(CLK_INFRA_UART2, "infra_uart2",
> "uart_sel", 24),
> - GATE_INFRA0(CLK_INFRA_UART3, "infra_uart3",
> - "uart_sel", 25),
> GATE_INFRA0(CLK_INFRA_GCE_26M, "infra_gce_26m",
> "axi_sel", 27),
> GATE_INFRA0(CLK_INFRA_CQ_DMA_FPC, "infra_cqdma_fpc",
>
Hi all,
Gentle ping on this patch.
Thanks!
Hanks Chen
On Wed, 2020-07-22 at 17:21 +0200, Matthias Brugger wrote:
>
> On 22/07/2020 13:16, Hanks Chen wrote:
> > On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote:
> >>
> >> On 22/07/2020 05:09, Hanks Chen wrote:
> >>> remove the redundant clk interface of uart.
> >>> CLK_INFRA_UART3 is a dummy clk interface,
> >>> it has no effect on the operation of the read/write instruction.
> >>>
> >>> Change since v2:
> >>> Commit "dt-bindings: clock: remove UART3 clock support"
> >>
> >> Sorry just another comment. I think we can make this one patch deleting everything.
> >>
> > Sorry, I don't understand the comment. Do I need to merge them into one
> > big patch?
> > Btw, if I use one patch, I would get check patch fail.
> > ---
> > [2020-07-22 19:12:49,046 ERROR] Run check patch results:
> > WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a
> > separate patch. See:
> > Documentation/devicetree/bindings/submitting-patches.rst
> > ---
>
> Hm, I think that's a debatable error message from checkpatch, but let's leave it
> as it is.
>
> Regards,
> Matthias
>
>
> >
> > Hanks
> >
> >>> -- remove Fixes tag
> >>> Commit "clk: mediatek: remove UART3 clock support"
> >>> -- remove Fixes tag
> >>>
> >>> Hanks Chen (2):
> >>> dt-bindings: clock: remove UART3 clock support
> >>> clk: mediatek: remove UART3 clock support
> >>>
> >>> drivers/clk/mediatek/clk-mt6779.c | 2 --
> >>> include/dt-bindings/clock/mt6779-clk.h | 1 -
> >>> 2 files changed, 3 deletions(-)
> >>>
> >
Hi all,
Gentle ping on this patch set.
Thanks!
Hanks Chen
On Thu, 2020-07-30 at 21:04 +0800, Hanks Chen wrote:
> Hi all,
>
> Gentle ping on this patch.
>
> Thanks!
>
> Hanks Chen
>
>
> On Wed, 2020-07-22 at 17:21 +0200, Matthias Brugger wrote:
> >
> > On 22/07/2020 13:16, Hanks Chen wrote:
> > > On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote:
> > >>
> > >> On 22/07/2020 05:09, Hanks Chen wrote:
> > >>> remove the redundant clk interface of uart.
> > >>> CLK_INFRA_UART3 is a dummy clk interface,
> > >>> it has no effect on the operation of the read/write instruction.
> > >>>
> > >>> Change since v2:
> > >>> Commit "dt-bindings: clock: remove UART3 clock support"
> > >>
> > >> Sorry just another comment. I think we can make this one patch deleting everything.
> > >>
> > > Sorry, I don't understand the comment. Do I need to merge them into one
> > > big patch?
> > > Btw, if I use one patch, I would get check patch fail.
> > > ---
> > > [2020-07-22 19:12:49,046 ERROR] Run check patch results:
> > > WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a
> > > separate patch. See:
> > > Documentation/devicetree/bindings/submitting-patches.rst
> > > ---
> >
> > Hm, I think that's a debatable error message from checkpatch, but let's leave it
> > as it is.
> >
> > Regards,
> > Matthias
> >
> >
> > >
> > > Hanks
> > >
> > >>> -- remove Fixes tag
> > >>> Commit "clk: mediatek: remove UART3 clock support"
> > >>> -- remove Fixes tag
> > >>>
> > >>> Hanks Chen (2):
> > >>> dt-bindings: clock: remove UART3 clock support
> > >>> clk: mediatek: remove UART3 clock support
> > >>>
> > >>> drivers/clk/mediatek/clk-mt6779.c | 2 --
> > >>> include/dt-bindings/clock/mt6779-clk.h | 1 -
> > >>> 2 files changed, 3 deletions(-)
> > >>>
> > >
>
> _______________________________________________
> Linux-mediatek mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Hi Michael & Stephen,
Gentle ping on this clk patch.
Thanks.
Regards,
Hanks
On Tue, 2020-09-08 at 14:31 +0800, Hanks Chen wrote:
> Hi all,
>
> Gentle ping on this patch set.
>
> Thanks!
>
>
> Hanks Chen
>
>
> On Thu, 2020-07-30 at 21:04 +0800, Hanks Chen wrote:
> > Hi all,
> >
> > Gentle ping on this patch.
> >
> > Thanks!
> >
> > Hanks Chen
> >
> >
> > On Wed, 2020-07-22 at 17:21 +0200, Matthias Brugger wrote:
> > >
> > > On 22/07/2020 13:16, Hanks Chen wrote:
> > > > On Wed, 2020-07-22 at 10:43 +0200, Matthias Brugger wrote:
> > > >>
> > > >> On 22/07/2020 05:09, Hanks Chen wrote:
> > > >>> remove the redundant clk interface of uart.
> > > >>> CLK_INFRA_UART3 is a dummy clk interface,
> > > >>> it has no effect on the operation of the read/write instruction.
> > > >>>
> > > >>> Change since v2:
> > > >>> Commit "dt-bindings: clock: remove UART3 clock support"
> > > >>
> > > >> Sorry just another comment. I think we can make this one patch deleting everything.
> > > >>
> > > > Sorry, I don't understand the comment. Do I need to merge them into one
> > > > big patch?
> > > > Btw, if I use one patch, I would get check patch fail.
> > > > ---
> > > > [2020-07-22 19:12:49,046 ERROR] Run check patch results:
> > > > WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a
> > > > separate patch. See:
> > > > Documentation/devicetree/bindings/submitting-patches.rst
> > > > ---
> > >
> > > Hm, I think that's a debatable error message from checkpatch, but let's leave it
> > > as it is.
> > >
> > > Regards,
> > > Matthias
> > >
> > >
> > > >
> > > > Hanks
> > > >
> > > >>> -- remove Fixes tag
> > > >>> Commit "clk: mediatek: remove UART3 clock support"
> > > >>> -- remove Fixes tag
> > > >>>
> > > >>> Hanks Chen (2):
> > > >>> dt-bindings: clock: remove UART3 clock support
> > > >>> clk: mediatek: remove UART3 clock support
> > > >>>
> > > >>> drivers/clk/mediatek/clk-mt6779.c | 2 --
> > > >>> include/dt-bindings/clock/mt6779-clk.h | 1 -
> > > >>> 2 files changed, 3 deletions(-)
> > > >>>
> > > >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > [email protected]
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
> _______________________________________________
> Linux-mediatek mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-mediatek