2020-07-29 15:33:44

by Sivaprakash Murugesan

Subject: [PATCH V2 1/7] dt-bindings: PCI: qcom: Add ipq8074 Gen3 PCIe compatible

ipq8074 has two PCIe ports while the support for Gen2 PCIe port is
already available add the support for Gen3 binding.

Co-developed-by: Selvam Sathappan Periakaruppan <[email protected]>
Signed-off-by: Selvam Sathappan Periakaruppan <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
Signed-off-by: Sivaprakash Murugesan <[email protected]>
---
.../devicetree/bindings/pci/qcom,pcie.yaml | 47 ++++++++++++++++++++++
1 file changed, 47 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 2eef6d5..e0559dd 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -23,6 +23,7 @@ properties:
- qcom,pcie-ipq8064
- qcom,pcie-ipq8064-v2
- qcom,pcie-ipq8074
+ - qcom,pcie-ipq8074-gen3
- qcom,pcie-msm8996
- qcom,pcie-qcs404
- qcom,pcie-sdm845
@@ -295,6 +296,52 @@ allOf:
compatible:
contains:
enum:
+ - qcom,pcie-ipq8074-gen3
+ then:
+ properties:
+ clocks:
+ items:
+ - description: sys noc interface clock
+ - description: AXI master clock
+ - description: AXI secondary clock
+ - description: AHB clock
+ - description: Auxilary clock
+ - description: AXI secondary bridge clock
+ - description: PCIe rchng clock
+ clock-names:
+ items:
+ - const: iface
+ - const: axi_m
+ - const: axi_s
+ - const: ahb
+ - const: aux
+ - const: axi_bridge
+ - const: rchng
+ resets:
+ items:
+ - description: PIPE reset
+ - description: PCIe sleep reset
+ - description: PCIe sticky reset
+ - description: AXI master reset
+ - description: AXI secondary reset
+ - description: AHB reset
+ - description: AXI master sticky reset
+ - description: AXI secondary sticky reset
+ reset-names:
+ items:
+ - const: pipe
+ - const: sleep
+ - const: sticky
+ - const: axi_m
+ - const: axi_s
+ - const: ahb
+ - const: axi_m_sticky
+ - const: axi_s_sticky
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
- qcom,pcie-msm8996
then:
properties:
--
2.7.4

2020-08-23 15:34:09

by Vinod Koul

Subject: Re: [PATCH V2 1/7] dt-bindings: PCI: qcom: Add ipq8074 Gen3 PCIe compatible

On 29-07-20, 21:00, Sivaprakash Murugesan wrote:
> ipq8074 has two PCIe ports while the support for Gen2 PCIe port is
> already available add the support for Gen3 binding.
>
> Co-developed-by: Selvam Sathappan Periakaruppan <[email protected]>
> Signed-off-by: Selvam Sathappan Periakaruppan <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> Signed-off-by: Sivaprakash Murugesan <[email protected]>
> ---
> .../devicetree/bindings/pci/qcom,pcie.yaml | 47 ++++++++++++++++++++++

The issue is the yaml file is not in linux-phy next.. did we get the
conversion done?

> 1 file changed, 47 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index 2eef6d5..e0559dd 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -23,6 +23,7 @@ properties:
> - qcom,pcie-ipq8064
> - qcom,pcie-ipq8064-v2
> - qcom,pcie-ipq8074
> + - qcom,pcie-ipq8074-gen3
> - qcom,pcie-msm8996
> - qcom,pcie-qcs404
> - qcom,pcie-sdm845
> @@ -295,6 +296,52 @@ allOf:
> compatible:
> contains:
> enum:
> + - qcom,pcie-ipq8074-gen3
> + then:
> + properties:
> + clocks:
> + items:
> + - description: sys noc interface clock
> + - description: AXI master clock
> + - description: AXI secondary clock
> + - description: AHB clock
> + - description: Auxilary clock
> + - description: AXI secondary bridge clock
> + - description: PCIe rchng clock
> + clock-names:
> + items:
> + - const: iface
> + - const: axi_m
> + - const: axi_s
> + - const: ahb
> + - const: aux
> + - const: axi_bridge
> + - const: rchng
> + resets:
> + items:
> + - description: PIPE reset
> + - description: PCIe sleep reset
> + - description: PCIe sticky reset
> + - description: AXI master reset
> + - description: AXI secondary reset
> + - description: AHB reset
> + - description: AXI master sticky reset
> + - description: AXI secondary sticky reset
> + reset-names:
> + items:
> + - const: pipe
> + - const: sleep
> + - const: sticky
> + - const: axi_m
> + - const: axi_s
> + - const: ahb
> + - const: axi_m_sticky
> + - const: axi_s_sticky
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> - qcom,pcie-msm8996
> then:
> properties:
> --
> 2.7.4

--
~Vinod