2020-07-30 06:45:33

by Li Heng

Subject: [PATCH -next] bnxt_en: Remove superfluous memset()

Fixes coccicheck warning:

./drivers/net/ethernet/broadcom/bnxt/bnxt.c:3730:19-37: WARNING:
dma_alloc_coherent use in stats -> hw_stats already zeroes out
memory, so memset is not needed

dma_alloc_coherent use in status already zeroes out memory,
so memset is not needed

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Li Heng <[email protected]>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 2622d3c..31fb5a2 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -3732,8 +3732,6 @@ static int bnxt_alloc_stats_mem(struct bnxt *bp, struct bnxt_stats_mem *stats,
if (!stats->hw_stats)
return -ENOMEM;

- memset(stats->hw_stats, 0, stats->len);
-
stats->sw_stats = kzalloc(stats->len, GFP_KERNEL);
if (!stats->sw_stats)
goto stats_mem_err;
--
2.7.4

2020-07-31 00:42:33

by David Miller

Subject: Re: [PATCH -next] bnxt_en: Remove superfluous memset()

From: Li Heng <[email protected]>
Date: Thu, 30 Jul 2020 14:43:50 +0800

> Fixes coccicheck warning:
>
> ./drivers/net/ethernet/broadcom/bnxt/bnxt.c:3730:19-37: WARNING:
> dma_alloc_coherent use in stats -> hw_stats already zeroes out
> memory, so memset is not needed
>
> dma_alloc_coherent use in status already zeroes out memory,
> so memset is not needed
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Li Heng <[email protected]>

Applied.