2020-07-30 13:31:05

by Hanks Chen

[permalink] [raw]
Subject: [PATCH v10 3/3] clk: mediatek: add UART0 clock support

Add MT6779 UART0 clock support.

Fixes: 710774e04861 ("clk: mediatek: Add MT6779 clock support")
Signed-off-by: Wendell Lin <[email protected]>
Signed-off-by: Hanks Chen <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]>
---
drivers/clk/mediatek/clk-mt6779.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/clk/mediatek/clk-mt6779.c b/drivers/clk/mediatek/clk-mt6779.c
index 9766cccf5844..6e0d3a166729 100644
--- a/drivers/clk/mediatek/clk-mt6779.c
+++ b/drivers/clk/mediatek/clk-mt6779.c
@@ -919,6 +919,8 @@ static const struct mtk_gate infra_clks[] = {
"pwm_sel", 19),
GATE_INFRA0(CLK_INFRA_PWM, "infra_pwm",
"pwm_sel", 21),
+ GATE_INFRA0(CLK_INFRA_UART0, "infra_uart0",
+ "uart_sel", 22),
GATE_INFRA0(CLK_INFRA_UART1, "infra_uart1",
"uart_sel", 23),
GATE_INFRA0(CLK_INFRA_UART2, "infra_uart2",
--
2.18.0


2020-09-08 06:26:32

by Hanks Chen

[permalink] [raw]
Subject: Re: [PATCH v10 3/3] clk: mediatek: add UART0 clock support

Hi all,

Gentle ping on this patch.

Thanks


Hanks Chen


On Thu, 2020-07-30 at 21:30 +0800, Hanks Chen wrote:
> Add MT6779 UART0 clock support.
>
> Fixes: 710774e04861 ("clk: mediatek: Add MT6779 clock support")
> Signed-off-by: Wendell Lin <[email protected]>
> Signed-off-by: Hanks Chen <[email protected]>
> Reviewed-by: Matthias Brugger <[email protected]>
> ---
> drivers/clk/mediatek/clk-mt6779.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/mediatek/clk-mt6779.c b/drivers/clk/mediatek/clk-mt6779.c
> index 9766cccf5844..6e0d3a166729 100644
> --- a/drivers/clk/mediatek/clk-mt6779.c
> +++ b/drivers/clk/mediatek/clk-mt6779.c
> @@ -919,6 +919,8 @@ static const struct mtk_gate infra_clks[] = {
> "pwm_sel", 19),
> GATE_INFRA0(CLK_INFRA_PWM, "infra_pwm",
> "pwm_sel", 21),
> + GATE_INFRA0(CLK_INFRA_UART0, "infra_uart0",
> + "uart_sel", 22),
> GATE_INFRA0(CLK_INFRA_UART1, "infra_uart1",
> "uart_sel", 23),
> GATE_INFRA0(CLK_INFRA_UART2, "infra_uart2",

2020-10-03 10:10:14

by Hanks Chen

[permalink] [raw]
Subject: Re: [PATCH v10 3/3] clk: mediatek: add UART0 clock support

Hi Michael & Stephen,

Please kindly let me know your comments about this patch.
Thanks

Regards,
Hanks


On Tue, 2020-09-08 at 14:25 +0800, Hanks Chen wrote:
> Hi all,
>
> Gentle ping on this patch.
>
> Thanks
>
>
> Hanks Chen
>
>
> On Thu, 2020-07-30 at 21:30 +0800, Hanks Chen wrote:
> > Add MT6779 UART0 clock support.
> >
> > Fixes: 710774e04861 ("clk: mediatek: Add MT6779 clock support")
> > Signed-off-by: Wendell Lin <[email protected]>
> > Signed-off-by: Hanks Chen <[email protected]>
> > Reviewed-by: Matthias Brugger <[email protected]>
> > ---
> > drivers/clk/mediatek/clk-mt6779.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/clk/mediatek/clk-mt6779.c b/drivers/clk/mediatek/clk-mt6779.c
> > index 9766cccf5844..6e0d3a166729 100644
> > --- a/drivers/clk/mediatek/clk-mt6779.c
> > +++ b/drivers/clk/mediatek/clk-mt6779.c
> > @@ -919,6 +919,8 @@ static const struct mtk_gate infra_clks[] = {
> > "pwm_sel", 19),
> > GATE_INFRA0(CLK_INFRA_PWM, "infra_pwm",
> > "pwm_sel", 21),
> > + GATE_INFRA0(CLK_INFRA_UART0, "infra_uart0",
> > + "uart_sel", 22),
> > GATE_INFRA0(CLK_INFRA_UART1, "infra_uart1",
> > "uart_sel", 23),
> > GATE_INFRA0(CLK_INFRA_UART2, "infra_uart2",
>
> _______________________________________________
> Linux-mediatek mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

2020-10-08 02:01:39

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v10 3/3] clk: mediatek: add UART0 clock support

Quoting Hanks Chen (2020-10-03 03:06:47)
> Hi Michael & Stephen,
>
> Please kindly let me know your comments about this patch.
> Thanks
>

What's the base for this patch? I tried applying to v5.9-rc1 and it
didn't work.

2020-10-08 02:43:09

by Hanks Chen

[permalink] [raw]
Subject: Re: [PATCH v10 3/3] clk: mediatek: add UART0 clock support

On Wed, 2020-10-07 at 19:00 -0700, Stephen Boyd wrote:
> Quoting Hanks Chen (2020-10-03 03:06:47)
> > Hi Michael & Stephen,
> >
> > Please kindly let me know your comments about this patch.
> > Thanks
> >
>
> What's the base for this patch? I tried applying to v5.9-rc1 and it
> didn't work.

Sorry, what does that mean?

Do you have encountered a merged conflict or run time failed?

I based on kernel-5.8-rc1 to add it and it can boot to kernel shell.

Thanks!


Hanks Chen

2020-10-08 08:35:05

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH v10 3/3] clk: mediatek: add UART0 clock support

Hi Stephen,

On 08/10/2020 04:00, Stephen Boyd wrote:
> Quoting Hanks Chen (2020-10-03 03:06:47)
>> Hi Michael & Stephen,
>>
>> Please kindly let me know your comments about this patch.
>> Thanks
>>
>
> What's the base for this patch? I tried applying to v5.9-rc1 and it
> didn't work.
>

Can you please double check. The file the patch touches didn't get touched since
v5.5-rc1. I tried to apply it and it didn't give me any error. I paste my way of
applying patches just in case:

b4.sh am -l -o /tmp -n patch -P 3
[email protected] && git am -3 -s
/tmp/patch.mbx

Regards,
Matthias

2020-10-08 21:59:40

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v10 3/3] clk: mediatek: add UART0 clock support

Quoting Hanks Chen (2020-10-07 19:39:13)
> On Wed, 2020-10-07 at 19:00 -0700, Stephen Boyd wrote:
> > Quoting Hanks Chen (2020-10-03 03:06:47)
> > > Hi Michael & Stephen,
> > >
> > > Please kindly let me know your comments about this patch.
> > > Thanks
> > >
> >
> > What's the base for this patch? I tried applying to v5.9-rc1 and it
> > didn't work.
>
> Sorry, what does that mean?
>
> Do you have encountered a merged conflict or run time failed?
>
> I based on kernel-5.8-rc1 to add it and it can boot to kernel shell.
>

Ah I see what it is. The email isn't actually plain text, it is base64
encoded and so git am gets confused by the CRLF line endings that are
encoded in there. Any chance you can send patches in actual plain text
format in the future?

2020-10-09 00:02:23

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v10 3/3] clk: mediatek: add UART0 clock support

Quoting Hanks Chen (2020-07-30 06:30:16)
> Add MT6779 UART0 clock support.
>
> Fixes: 710774e04861 ("clk: mediatek: Add MT6779 clock support")
> Signed-off-by: Wendell Lin <[email protected]>
> Signed-off-by: Hanks Chen <[email protected]>
> Reviewed-by: Matthias Brugger <[email protected]>
> ---

Applied to clk-next