2020-08-06 06:25:52

by Mansur Alisha Shaik

Subject: [PATCH V3] venus: core: add shutdown callback for venus

After the SMMU translation is disabled in the
arm-smmu shutdown callback during reboot, if
any subsystem are still alive then IOVAs they
are using will become PAs on bus, which may
lead to crash.

Below are the consumers of smmu from venus
arm-smmu: consumer: aa00000.video-codec supplier=15000000.iommu
arm-smmu: consumer: video-firmware.0 supplier=15000000.iommu

So implemented shutdown callback, which detach iommu maps.

Signed-off-by: Mansur Alisha Shaik <[email protected]>
---
Changes in V3:
- Fix build errors

drivers/media/platform/qcom/venus/core.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index 203c653..cfe211a 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -341,6 +341,16 @@ static int venus_remove(struct platform_device *pdev)
return ret;
}

+static void venus_core_shutdown(struct platform_device *pdev)
+{
+ struct venus_core *core = platform_get_drvdata(pdev);
+ int ret;
+
+ ret = venus_remove(pdev);
+ if (ret)
+ dev_warn(core->dev, "shutdown failed %d\n", ret);
+}
+
static __maybe_unused int venus_runtime_suspend(struct device *dev)
{
struct venus_core *core = dev_get_drvdata(dev);
@@ -592,6 +602,7 @@ static struct platform_driver qcom_venus_driver = {
.of_match_table = venus_dt_match,
.pm = &venus_pm_ops,
},
+ .shutdown = venus_core_shutdown,
};
module_platform_driver(qcom_venus_driver);

--
2.7.4

2020-08-17 09:46:34

by Stanimir Varbanov

Subject: Re: [PATCH V3] venus: core: add shutdown callback for venus

Hi Mansur,

On 8/6/20 9:21 AM, Mansur Alisha Shaik wrote:
> After the SMMU translation is disabled in the
> arm-smmu shutdown callback during reboot, if
> any subsystem are still alive then IOVAs they
> are using will become PAs on bus, which may
> lead to crash.
>
> Below are the consumers of smmu from venus
> arm-smmu: consumer: aa00000.video-codec supplier=15000000.iommu
> arm-smmu: consumer: video-firmware.0 supplier=15000000.iommu
>
> So implemented shutdown callback, which detach iommu maps.
>
> Signed-off-by: Mansur Alisha Shaik <[email protected]>
> ---
> Changes in V3:
> - Fix build errors
>
> drivers/media/platform/qcom/venus/core.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)

As there is no more comments and it looks good to me:

Acked-by: Stanimir Varbanov <[email protected]>

>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 203c653..cfe211a 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -341,6 +341,16 @@ static int venus_remove(struct platform_device *pdev)
> return ret;
> }
>
> +static void venus_core_shutdown(struct platform_device *pdev)
> +{
> + struct venus_core *core = platform_get_drvdata(pdev);
> + int ret;
> +
> + ret = venus_remove(pdev);
> + if (ret)
> + dev_warn(core->dev, "shutdown failed %d\n", ret);
> +}
> +
> static __maybe_unused int venus_runtime_suspend(struct device *dev)
> {
> struct venus_core *core = dev_get_drvdata(dev);
> @@ -592,6 +602,7 @@ static struct platform_driver qcom_venus_driver = {
> .of_match_table = venus_dt_match,
> .pm = &venus_pm_ops,
> },
> + .shutdown = venus_core_shutdown,
> };
> module_platform_driver(qcom_venus_driver);
>
>

--
regards,
Stan