2020-08-12 09:40:00

by Wenbin Mei (梅文彬)

Subject: [PATCH 0/3] mmc: mediatek: add optional module reset property mmc: mediatek: add optional module reset property arm64: dts: mt7622: add reset node for mmc device Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++ arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++ drivers/mmc/host/mtk-sd.c | 13 +++++++++++++ 3 files changed, 17 insertions(+)

--
2.18.0

2020-08-12 09:40:21

by Wenbin Mei (梅文彬)

Subject: [PATCH 2/3] arm64: dts: mt7622: add reset node for mmc device

This commit adds reset node for mmc device.

Signed-off-by: Wenbin Mei <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 1a39e0ef776b..5b9ec032ce8d 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -686,6 +686,8 @@
clocks = <&pericfg CLK_PERI_MSDC30_0_PD>,
<&topckgen CLK_TOP_MSDC50_0_SEL>;
clock-names = "source", "hclk";
+ resets = <&pericfg MT7622_PERI_MSDC0_SW_RST>;
+ reset-names = "hrst";
status = "disabled";
};

--
2.18.0

2020-08-12 10:34:53

by Frank Wunderlich

Subject: Aw: [PATCH 2/3] arm64: dts: mt7622: add reset node for mmc device

> Gesendet: Mittwoch, 12. August 2020 um 11:37 Uhr
> Von: "Wenbin Mei" <[email protected]>
> Betreff: [PATCH 3/3] mmc: mediatek: add optional module reset property

> This patch adds a optional reset management for msdc.
> Sometimes the bootloader does not bring msdc register
> to default state, so need reset the msdc controller.
>
> Signed-off-by: Wenbin Mei <[email protected]>

Thanks for posting the fix to Mainline
same as 3/3, dts-patch is also needed for fixing eMMC-Issue on R64

Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
Tested-By: Frank Wunderlich <[email protected]>

and it needs to be fixed at least for 5.4+, so adding stable-CC

Cc: [email protected]

2020-08-12 11:59:24

by Wenbin Mei (梅文彬)

Subject: Re: Aw: [PATCH 2/3] arm64: dts: mt7622: add reset node for mmc device

Thanks for your reply.
I will add this in the next version.
On Wed, 2020-08-12 at 12:33 +0200, Frank Wunderlich wrote:
> > Gesendet: Mittwoch, 12. August 2020 um 11:37 Uhr
> > Von: "Wenbin Mei" <[email protected]>
> > Betreff: [PATCH 3/3] mmc: mediatek: add optional module reset property
>
> > This patch adds a optional reset management for msdc.
> > Sometimes the bootloader does not bring msdc register
> > to default state, so need reset the msdc controller.
> >
> > Signed-off-by: Wenbin Mei <[email protected]>
>
> Thanks for posting the fix to Mainline
> same as 3/3, dts-patch is also needed for fixing eMMC-Issue on R64
>
> Fixes: 966580ad236e ("mmc: mediatek: add support for MT7622 SoC")
> Tested-By: Frank Wunderlich <[email protected]>
>
> and it needs to be fixed at least for 5.4+, so adding stable-CC
>
> Cc: [email protected]