2020-08-16 09:14:49

by Vinay Simha B N

[permalink] [raw]
Subject: [PATCH] drm/bridge/tc358775: Fix for PTR_ERR

passing zero to 'PTR_ERR'

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Vinay Simha BN <[email protected]>
---
drivers/gpu/drm/bridge/tc358775.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
index 7da15cd..d951cdc 100644
--- a/drivers/gpu/drm/bridge/tc358775.c
+++ b/drivers/gpu/drm/bridge/tc358775.c
@@ -684,7 +684,7 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)

tc->vdd = devm_regulator_get(dev, "vdd-supply");
if (IS_ERR(tc->vdd)) {
- ret = PTR_ERR(tc->vddio);
+ ret = PTR_ERR(tc->vdd);
dev_err(dev, "vdd-supply not found\n");
return ret;
}
--
2.7.4


2020-08-23 15:51:13

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH] drm/bridge/tc358775: Fix for PTR_ERR

On Sun, Aug 16, 2020 at 11:20:41AM +0530, Vinay Simha BN wrote:
> passing zero to 'PTR_ERR'
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Vinay Simha BN <[email protected]>

Applied to drm-misc-next - thanks.

Sam

> ---
> drivers/gpu/drm/bridge/tc358775.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
> index 7da15cd..d951cdc 100644
> --- a/drivers/gpu/drm/bridge/tc358775.c
> +++ b/drivers/gpu/drm/bridge/tc358775.c
> @@ -684,7 +684,7 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)
>
> tc->vdd = devm_regulator_get(dev, "vdd-supply");
> if (IS_ERR(tc->vdd)) {
> - ret = PTR_ERR(tc->vddio);
> + ret = PTR_ERR(tc->vdd);
> dev_err(dev, "vdd-supply not found\n");
> return ret;
> }
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

2020-08-23 16:59:26

by Vinay Simha B N

[permalink] [raw]
Subject: Re: [PATCH] drm/bridge/tc358775: Fix for PTR_ERR

Thanks Sam.

On Sun, Aug 23, 2020 at 8:35 PM Sam Ravnborg <[email protected]> wrote:
>
> On Sun, Aug 16, 2020 at 11:20:41AM +0530, Vinay Simha BN wrote:
> > passing zero to 'PTR_ERR'
> >
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Vinay Simha BN <[email protected]>
>
> Applied to drm-misc-next - thanks.
>
> Sam
>
> > ---
> > drivers/gpu/drm/bridge/tc358775.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
> > index 7da15cd..d951cdc 100644
> > --- a/drivers/gpu/drm/bridge/tc358775.c
> > +++ b/drivers/gpu/drm/bridge/tc358775.c
> > @@ -684,7 +684,7 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)
> >
> > tc->vdd = devm_regulator_get(dev, "vdd-supply");
> > if (IS_ERR(tc->vdd)) {
> > - ret = PTR_ERR(tc->vddio);
> > + ret = PTR_ERR(tc->vdd);
> > dev_err(dev, "vdd-supply not found\n");
> > return ret;
> > }
> > --
> > 2.7.4
> >
> > _______________________________________________
> > dri-devel mailing list
> > [email protected]
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel



--
regards,
vinaysimha