2020-08-10 02:00:11

by Jisheng Zhang

[permalink] [raw]
Subject: [PATCH] regulator: sy8827n: Fix W=1 build warning when CONFIG_OF=n

Fixing W=1 build warning when no support for device tree is there.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Jisheng Zhang <[email protected]>
---
drivers/regulator/sy8827n.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/sy8827n.c b/drivers/regulator/sy8827n.c
index b207217f74d8..52e8c17afe24 100644
--- a/drivers/regulator/sy8827n.c
+++ b/drivers/regulator/sy8827n.c
@@ -156,6 +156,7 @@ static int sy8827n_i2c_probe(struct i2c_client *client)
return ret;
}

+#ifdef CONFIG_OF
static const struct of_device_id sy8827n_dt_ids[] = {
{
.compatible = "silergy,sy8827n",
@@ -163,6 +164,7 @@ static const struct of_device_id sy8827n_dt_ids[] = {
{ }
};
MODULE_DEVICE_TABLE(of, sy8827n_dt_ids);
+#endif

static const struct i2c_device_id sy8827n_id[] = {
{ "sy8827n", },
--
2.28.0


2020-08-18 17:00:48

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: sy8827n: Fix W=1 build warning when CONFIG_OF=n

On Mon, 10 Aug 2020 09:57:53 +0800, Jisheng Zhang wrote:
> Fixing W=1 build warning when no support for device tree is there.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: sy8827n: Fix W=1 build warning when CONFIG_OF=n
commit: a16138a32eeeca01e2603193288ff0714bead11d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark