by Chuanhong Guo

[permalink] [raw]

Subject: Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch

Hi!

On Thu, Aug 20, 2020 at 7:55 AM René van Dorst <[email protected]> wrote:
>
> With the current mainline code [1], the dsa code tries to detect how the MAC5
> is used. All the three modes are supported. MAC5 -> PHY0, MAC5 ->
> PHY4, MAC5 ->
> EXTERNAL PHY and MAC5 to external MAC.
>
> When MAC5 is a DSA port it skips settings the delay settings. See [2].
>
> Maybe you can use a similar concept.

Current detection relies on an incorrect assumption that mt753x switch
is always used with mtk_eth_soc. It's a really hacky solution to use
dt properties that don't belong to this switch at all and I think this
approach should not be followed further by future code.
The usage of mac5 should be explicitly defined as a dt property
under mt753x node.
--
Regards,
Chuanhong Guo

2020-08-25 19:45:47

by Rob Herring (Arm)

[permalink] [raw]

Subject: Re: [PATCH net-next v2 4/7] dt-bindings: net: dsa: add new MT7531 binding to support MT7531

On Tue, Aug 18, 2020 at 03:14:09PM +0800, Landen Chao wrote:
> Add devicetree binding to support the compatible mt7531 switch as used
> in the MediaTek MT7531 switch.
>
> Signed-off-by: Sean Wang <[email protected]>
> Signed-off-by: Landen Chao <[email protected]>
> ---
> .../devicetree/bindings/net/dsa/mt7530.txt | 71 ++++++++++++++++++-
> 1 file changed, 68 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/mt7530.txt b/Documentation/devicetree/bindings/net/dsa/mt7530.txt
> index c5ed5d25f642..50eaf40fb612 100644
> --- a/Documentation/devicetree/bindings/net/dsa/mt7530.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/mt7530.txt
> @@ -5,6 +5,7 @@ Required properties:
>
> - compatible: may be compatible = "mediatek,mt7530"
> or compatible = "mediatek,mt7621"
> + or compatible = "mediatek,mt7531"
> - #address-cells: Must be 1.
> - #size-cells: Must be 0.
> - mediatek,mcm: Boolean; if defined, indicates that either MT7530 is the part
> @@ -32,10 +33,13 @@ Required properties for the child nodes within ports container:
>
> - reg: Port address described must be 6 for CPU port and from 0 to 5 for
> user ports.
> -- phy-mode: String, must be either "trgmii" or "rgmii" for port labeled
> - "cpu".
> +- phy-mode: String, the follow value would be acceptable for port labeled "cpu"
> + If compatible mediatek,mt7530 or mediatek,mt7621 is set,
> + must be either "trgmii" or "rgmii"
> + If compatible mediatek,mt7531 is set,
> + must be either "sgmii", "1000base-x" or "2500base-x"
>
> -Port 5 of the switch is muxed between:
> +Port 5 of mt7530 and mt7621 switch is muxed between:
> 1. GMAC5: GMAC5 can interface with another external MAC or PHY.
> 2. PHY of port 0 or port 4: PHY interfaces with an external MAC like 2nd GMAC
> of the SOC. Used in many setups where port 0/4 becomes the WAN port.
> @@ -308,3 +312,64 @@ Example 3: MT7621: Port 5 is connected to external PHY: Port 5 -> external PHY.
> };
> };
> };
> +
> +Example 4: MT7531BE port6 -- up-clocked 2.5Gbps SGMII -- MT7622 CPU 1st GMAC

Does this really need another example?

> +
> +&eth {
> + gmac0: mac@0 {
> + compatible = "mediatek,eth-mac";
> + reg = <0>;
> + phy-mode = "2500base-x";
> +
> + fixed-link {
> + speed = <2500>;
> + full-duplex;
> + pause;
> + };
> + };
> +
> + &mdio0 {
> + switch@0 {
> + compatible = "mediatek,mt7531";
> + reg = <0>;
> + reset-gpios = <&pio 54 0>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> +
> + port@0 {
> + reg = <0>;
> + label = "lan0";
> + };
> +
> + port@1 {
> + reg = <1>;
> + label = "lan1";
> + };
> +
> + port@2 {
> + reg = <2>;
> + label = "lan2";
> + };
> +
> + port@3 {
> + reg = <3>;
> + label = "lan3";
> + };
> +
> + port@4 {
> + reg = <4>;
> + label = "wan";
> + };
> +
> + port@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <&gmac0>;
> + phy-mode = "2500base-x";
> + };
> + };
> + };
> + };
> --
> 2.17.1