2020-09-09 20:48:43

by Amit Sunil Dhamne

[permalink] [raw]
Subject: [PATCH v4 0/3] clk: zynqmp: Add firmware specific clock flags

Currently firmware is maintaining CCF specific flags and provides to
CCF as it is. But CCF flag numbers may change and that shouldn't mean
that the firmware needs to change. The firmware should have its own
'flag number space' that is distinct from the common clk framework's
'flag number space'. So use firmware specific clock flags in ZynqMP
clock driver instead of CCF flags.

Changes in v4:
- Use if condition instead of ternary operator.

Changes in v3:
- Modify helper function signature to map zynqmp (common)flags with CCF
- Add helper function to map zynqmp (mux & divider)flags with CCF flags

Changes in v2:
- Add helper function to map zynqmp (common)flags with CCF flags.
- Mapped zynqmp clock flags with CCF flags from
zynqmp_clk_register_*() functions instead of
__zynqmp_clock_get_topology() which is changing the flags to struct
clk_init_data instead of the struct clock_topology.

Rajan Vaja (3):
clk: zynqmp: Use firmware specific common clock flags
clk: zynqmp: Use firmware specific divider clock flags
clk: zynqmp: Use firmware specific mux clock flags

drivers/clk/zynqmp/clk-gate-zynqmp.c | 4 +++-
drivers/clk/zynqmp/clk-mux-zynqmp.c | 27 ++++++++++++++++++++++--
drivers/clk/zynqmp/clk-zynqmp.h | 41 ++++++++++++++++++++++++++++++++++++
drivers/clk/zynqmp/clkc.c | 33 ++++++++++++++++++++++++++++-
drivers/clk/zynqmp/divider.c | 30 +++++++++++++++++++++++---
drivers/clk/zynqmp/pll.c | 4 +++-
6 files changed, 131 insertions(+), 8 deletions(-)

--
2.7.4

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.


2020-09-22 20:11:01

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v4 0/3] clk: zynqmp: Add firmware specific clock flags

Quoting Amit Sunil Dhamne (2020-09-09 13:44:45)
> Currently firmware is maintaining CCF specific flags and provides to
> CCF as it is. But CCF flag numbers may change and that shouldn't mean
> that the firmware needs to change. The firmware should have its own
> 'flag number space' that is distinct from the common clk framework's
> 'flag number space'. So use firmware specific clock flags in ZynqMP
> clock driver instead of CCF flags.
>
> Changes in v4:
> - Use if condition instead of ternary operator.
>

Thanks. This patch series doesn't apply for me though. What is the base
of the patches? Can you use the --base option when formatting patches
with git format-patch? That would help me.

Also, I think your MUA or SMTP server is mangling the format. I had
trouble trying to apply the patches from my local copy so I had to
fallback to lore but even that didn't work.

Please resend.